gitlab-org--gitlab-foss/features/steps
Fatih Acet 4d37be0fb8 Merge branch '22781-user-generated-permalinks' into 'master'
Resolve "User-generated permalink IDs collide with GitLab interface"

## What does this MR do?

Prevents ID values automatically generated by headers in [GitLab Flavored Markdown](https://github.com/gitlabhq/gitlabhq/blob/master/doc/user/markdown.md#header-ids-and-links) from colliding with IDs used elsewhere in the GitLab interface.  This can cause confusion when, for instance, a selector looks for a merge request tab with `id="pipelines"` and there is a header with the same ID earlier in the DOM.

How this works:
* All header IDs generated with GitLab Flavored Markdown are namespaced with `id="user-content_foo"`
* All anchor links which point to these IDs continue to use the non-namespaced hash `<a href="#foo">...</a>`
* When a page is loaded or when the `hashchange` event is triggered, javascript will automatically search for `#user-content_foo` if `#foo` cannot be found, and scroll to that position instead.

## Before

![2016-11-21-13.00.28](/uploads/e3be2cd6a9142dfd6e64db5462a6aa76/2016-11-21-13.00.28.gif)

## After:

![2016-11-21-13.12.45](/uploads/f7ae3f3a30c91325eaa3665591b6a850/2016-11-21-13.12.45.gif)  
![2016-11-21-13.03.00](/uploads/3a6a782c081ecaa05b8781548d794909/2016-11-21-13.03.00.gif)  

## Does this MR meet the acceptance criteria?

- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- Tests
  - [x] Added for this feature/bug
  - [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

Closes #22781 

See also prior attempts to address this issue:
#3908, !2023, !2024


See merge request !7631
2016-12-01 20:58:08 +00:00
..
admin Merge branch 'move-admin-spam-spinach-test-to-rspec' into 'master' 2016-11-24 13:26:33 +00:00
dashboard Add Rake task to create/repair GitLab Shell hooks symlinks 2016-11-01 14:52:59 -05:00
explore Show member roles to all users on members page 2016-08-11 11:08:07 -05:00
group Fixed group tests 2016-09-13 08:44:59 +01:00
profile implements reset incoming email token on issues modal and account page, 2016-11-07 15:56:18 +00:00
project fix tests broken by new wiki page design 2016-11-30 15:22:43 -06:00
shared remove underscore from user-content id namespace 2016-11-30 15:28:11 -06:00
snippets Move 'Explore Snippets' Spinach feature to Rspec 2016-11-08 06:37:02 +00:00
groups.rb Update non-exist group spinach test to match routing 2016-11-08 10:13:13 +02:00
invites.rb
search.rb Fixed tests 2016-04-26 09:03:04 +01:00
user.rb tests update 2016-05-16 12:22:17 +01:00