b7abba0ca0
This changes the query to use a COUNT nested in an INNER JOIN, instead of a COUNT plus a GROUP BY. There are two reasons for this: 1. Using a COUNT in an INNER JOIN can be quite a bit faster. 2. The use of a GROUP BY means that method calls such as "any?" (and everything else that calls "count") operate on a Hash that counts the amount of notes on a per project basis, instead of just counting the total amount of projects. The query has been moved into Project.trending as its logic is simple enough. As a result of this testing the TrendingProjectsFinder class simply involves testing if the right methods are called, removing the need for setting up database records.
39 lines
922 B
Ruby
39 lines
922 B
Ruby
require 'spec_helper'
|
|
|
|
describe TrendingProjectsFinder do
|
|
let(:user) { build(:user) }
|
|
|
|
describe '#execute' do
|
|
describe 'without an explicit start date' do
|
|
subject { described_class.new }
|
|
|
|
it 'returns the trending projects' do
|
|
relation = double(:ar_relation)
|
|
|
|
allow(subject).to receive(:projects_for)
|
|
.with(user)
|
|
.and_return(relation)
|
|
|
|
allow(relation).to receive(:trending)
|
|
.with(an_instance_of(ActiveSupport::TimeWithZone))
|
|
end
|
|
end
|
|
|
|
describe 'with an explicit start date' do
|
|
let(:date) { 2.months.ago }
|
|
|
|
subject { described_class.new }
|
|
|
|
it 'returns the trending projects' do
|
|
relation = double(:ar_relation)
|
|
|
|
allow(subject).to receive(:projects_for)
|
|
.with(user)
|
|
.and_return(relation)
|
|
|
|
allow(relation).to receive(:trending)
|
|
.with(date)
|
|
end
|
|
end
|
|
end
|
|
end
|