41b51c0656
Users downloading non-ASCII attachments would see garbled characters. When used with object storage, AWS S3 would return an InvalidArgument error: Header value cannot be represented using ISO-8859-1. Per RFC 5987 and RFC 6266, Content-Disposition should be encoded properly. This commit takes the Rails 6 implementation of ActiveSuppport::Http::ContentDisposition (https://github.com/rails/rails/pull/33829) and ports it here. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/47673
34 lines
1.1 KiB
Ruby
34 lines
1.1 KiB
Ruby
require "spec_helper"
|
|
|
|
describe "User downloads artifacts" do
|
|
set(:project) { create(:project, :public) }
|
|
set(:pipeline) { create(:ci_empty_pipeline, status: :success, project: project) }
|
|
set(:job) { create(:ci_build, :artifacts, :success, pipeline: pipeline) }
|
|
|
|
shared_examples "downloading" do
|
|
it "downloads the zip" do
|
|
expect(page.response_headers["Content-Disposition"]).to eq(%Q{attachment; filename*=UTF-8''#{job.artifacts_file.filename}; filename="#{job.artifacts_file.filename}"})
|
|
expect(page.response_headers['Content-Transfer-Encoding']).to eq("binary")
|
|
expect(page.response_headers['Content-Type']).to eq("application/zip")
|
|
expect(page.source.b).to eq(job.artifacts_file.file.read.b)
|
|
end
|
|
end
|
|
|
|
context "when downloading" do
|
|
before do
|
|
visit(url)
|
|
end
|
|
|
|
context "via job id" do
|
|
let(:url) { download_project_job_artifacts_path(project, job) }
|
|
|
|
it_behaves_like "downloading"
|
|
end
|
|
|
|
context "via branch name and job name" do
|
|
let(:url) { latest_succeeded_project_artifacts_path(project, "#{pipeline.ref}/download", job: job.name) }
|
|
|
|
it_behaves_like "downloading"
|
|
end
|
|
end
|
|
end
|