6f3c490107
This refactors the AutocompleteController according to the guidelines and boundaries discussed in https://gitlab.com/gitlab-org/gitlab-ce/issues/49653. Specifically, ActiveRecord logic is moved to different finders, which are then used in the controller. View logic in turn is moved to presenters, instead of directly using ActiveRecord's "to_json" method. The finder MoveToProjectFinder is also adjusted according to the abstraction guidelines and boundaries, resulting in a much more simple finder. By using finders (and other abstractions) more actively, we can push a lot of logic out of the controller. We also remove the need for various "before_action" hooks, though this could be achieved without using finders as well. The various finders related to AutcompleteController have also been moved into a namespace. This removes the need for calling everything "AutocompleteSmurfFinder", instead you can use "Autocomplete::SmurfFinder".
25 lines
666 B
Ruby
25 lines
666 B
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
describe AwardedEmojiFinder do
|
|
describe '#execute' do
|
|
it 'returns an Array containing the awarded emoji names' do
|
|
user = create(:user)
|
|
|
|
create(:award_emoji, user: user, name: 'thumbsup')
|
|
create(:award_emoji, user: user, name: 'thumbsup')
|
|
create(:award_emoji, user: user, name: 'thumbsdown')
|
|
|
|
awarded = described_class.new(user).execute
|
|
|
|
expect(awarded).to eq([{ name: 'thumbsup' }, { name: 'thumbsdown' }])
|
|
end
|
|
|
|
it 'returns an empty Array when no user is given' do
|
|
awarded = described_class.new.execute
|
|
|
|
expect(awarded).to be_empty
|
|
end
|
|
end
|
|
end
|