3ab026b7d6
The Gitaly CommitService is being hammered by n + 1 calls, mostly when
finding commits. This leads to this gRPC being turned of on production:
https://gitlab.com/gitlab-org/gitaly/issues/514#note_48991378
Hunting down where it came from, most of them were due to
MergeRequest#show. To prove this, I set a script to request the
MergeRequest#show page 50 times. The GDK was being scraped by
Prometheus, where we have metrics on controller#action and their Gitaly
calls performed. On both occations I've restarted the full GDK so all
caches had to be rebuild.
Current master, 806a68a81f, needed 435 requests
After this commit, 154 requests
41 lines
1,006 B
Ruby
41 lines
1,006 B
Ruby
module Gitlab
|
|
module Utils
|
|
module StrongMemoize
|
|
# Instead of writing patterns like this:
|
|
#
|
|
# def trigger_from_token
|
|
# return @trigger if defined?(@trigger)
|
|
#
|
|
# @trigger = Ci::Trigger.find_by_token(params[:token].to_s)
|
|
# end
|
|
#
|
|
# We could write it like:
|
|
#
|
|
# include Gitlab::Utils::StrongMemoize
|
|
#
|
|
# def trigger_from_token
|
|
# strong_memoize(:trigger) do
|
|
# Ci::Trigger.find_by_token(params[:token].to_s)
|
|
# end
|
|
# end
|
|
#
|
|
def strong_memoize(name)
|
|
if instance_variable_defined?(ivar(name))
|
|
instance_variable_get(ivar(name))
|
|
else
|
|
instance_variable_set(ivar(name), yield)
|
|
end
|
|
end
|
|
|
|
def clear_memoization(name)
|
|
remove_instance_variable(ivar(name)) if instance_variable_defined?(ivar(name))
|
|
end
|
|
|
|
private
|
|
|
|
def ivar(name)
|
|
"@#{name}"
|
|
end
|
|
end
|
|
end
|
|
end
|