d0b8f536a1
This removes all usage of soft removals except for the "pending delete" system implemented for projects. This in turn simplifies all the query plans of the models that used soft removals. Since we don't really use soft removals for anything useful there's no point in keeping it around. This _does_ mean that hard removals of issues (which only admins can do if I'm not mistaken) can influence the "iid" values, but that code is broken to begin with. More on this (and how to fix it) can be found in https://gitlab.com/gitlab-org/gitlab-ce/issues/31114. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/37447
22 lines
457 B
Ruby
22 lines
457 B
Ruby
module InternalId
|
|
extend ActiveSupport::Concern
|
|
|
|
included do
|
|
validate :set_iid, on: :create
|
|
validates :iid, presence: true, numericality: true
|
|
end
|
|
|
|
def set_iid
|
|
if iid.blank?
|
|
parent = project || group
|
|
records = parent.public_send(self.class.name.tableize) # rubocop:disable GitlabSecurity/PublicSend
|
|
max_iid = records.maximum(:iid)
|
|
|
|
self.iid = max_iid.to_i + 1
|
|
end
|
|
end
|
|
|
|
def to_param
|
|
iid.to_s
|
|
end
|
|
end
|