6d37fe952b
Fix missing access checks on issue lookup using IssuableFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867 ⚠️ - Potentially untested 💣 - No test coverage 🚥 - Test coverage of some sort exists (a test failed when error raised) 🚦 - Test coverage of return value (a test failed when nil used) ✅ - Permissions check tested - [x] ✅ app/controllers/projects/branches_controller.rb:39 - `before_action :authorize_push_code!` helpes limit/prevent exploitation. Always checks for reporter access so fine with confidential issues, issues only visible to team, etc. - [x] 🚥 app/models/cycle_analytics/summary.rb:9 [`.count`] - [x] ✅ app/controllers/projects/todos_controller.rb:19 - [x] Potential double render in app/controllers/projects/todos_controller.rb - https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#cedccb227af9bfdf88802767cb58d43c2b977439_24_24 See merge request !2030
88 lines
2.8 KiB
Ruby
88 lines
2.8 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe 'CycleAnalytics#test', feature: true do
|
|
extend CycleAnalyticsHelpers::TestGeneration
|
|
|
|
let(:project) { create(:project) }
|
|
let(:from_date) { 10.days.ago }
|
|
let(:user) { create(:user, :admin) }
|
|
subject { CycleAnalytics.new(project, user, from: from_date) }
|
|
|
|
generate_cycle_analytics_spec(
|
|
phase: :test,
|
|
data_fn: lambda do |context|
|
|
issue = context.create(:issue, project: context.project)
|
|
merge_request = context.create_merge_request_closing_issue(issue)
|
|
pipeline = context.create(:ci_pipeline, ref: merge_request.source_branch, sha: merge_request.diff_head_sha, project: context.project)
|
|
{ pipeline: pipeline, issue: issue }
|
|
end,
|
|
start_time_conditions: [["pipeline is started", -> (context, data) { data[:pipeline].run! }]],
|
|
end_time_conditions: [["pipeline is finished", -> (context, data) { data[:pipeline].succeed! }]],
|
|
post_fn: -> (context, data) do
|
|
context.merge_merge_requests_closing_issue(data[:issue])
|
|
end)
|
|
|
|
context "when the pipeline is for a regular merge request (that doesn't close an issue)" do
|
|
it "returns nil" do
|
|
5.times do
|
|
issue = create(:issue, project: project)
|
|
merge_request = create_merge_request_closing_issue(issue)
|
|
pipeline = create(:ci_pipeline, ref: "refs/heads/#{merge_request.source_branch}", sha: merge_request.diff_head_sha)
|
|
|
|
pipeline.run!
|
|
pipeline.succeed!
|
|
|
|
merge_merge_requests_closing_issue(issue)
|
|
end
|
|
|
|
expect(subject.test).to be_nil
|
|
end
|
|
end
|
|
|
|
context "when the pipeline is not for a merge request" do
|
|
it "returns nil" do
|
|
5.times do
|
|
pipeline = create(:ci_pipeline, ref: "refs/heads/master", sha: project.repository.commit('master').sha)
|
|
|
|
pipeline.run!
|
|
pipeline.succeed!
|
|
end
|
|
|
|
expect(subject.test).to be_nil
|
|
end
|
|
end
|
|
|
|
context "when the pipeline is dropped (failed)" do
|
|
it "returns nil" do
|
|
5.times do
|
|
issue = create(:issue, project: project)
|
|
merge_request = create_merge_request_closing_issue(issue)
|
|
pipeline = create(:ci_pipeline, ref: "refs/heads/#{merge_request.source_branch}", sha: merge_request.diff_head_sha)
|
|
|
|
pipeline.run!
|
|
pipeline.drop!
|
|
|
|
merge_merge_requests_closing_issue(issue)
|
|
end
|
|
|
|
expect(subject.test).to be_nil
|
|
end
|
|
end
|
|
|
|
context "when the pipeline is cancelled" do
|
|
it "returns nil" do
|
|
5.times do
|
|
issue = create(:issue, project: project)
|
|
merge_request = create_merge_request_closing_issue(issue)
|
|
pipeline = create(:ci_pipeline, ref: "refs/heads/#{merge_request.source_branch}", sha: merge_request.diff_head_sha)
|
|
|
|
pipeline.run!
|
|
pipeline.cancel!
|
|
|
|
merge_merge_requests_closing_issue(issue)
|
|
end
|
|
|
|
expect(subject.test).to be_nil
|
|
end
|
|
end
|
|
end
|