gitlab-org--gitlab-foss/spec/lib/gitlab/middleware
Stan Hu 01203e7188 Fix health checks not working behind load balancers
The change in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24199 caused
requests coming from a load balancer to arrive as 127.0.0.1 instead of
the actual IP.

`Rack::Request#ip` behaves slightly differently different than
`ActionDispatch::Request#remote_ip`: the former will return the first
X-Forwarded-For IP if all of the IPs are trusted proxies, while the
second one filters out all proxies and falls back to REMOTE_ADDR, which
is 127.0.0.1.

For now, we can revert back to using `Rack::Request` because these
middlewares don't manipulate parameters. The actual fix problem involves
fixing Rails: https://github.com/rails/rails/issues/28436.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/58573
2019-03-12 12:46:40 -07:00
..
basic_health_check_spec.rb Fix health checks not working behind load balancers 2019-03-12 12:46:40 -07:00
go_spec.rb Fix lint errors 2019-01-03 20:28:02 +08:00
multipart_spec.rb Fix multipart attachments not uploading 2019-01-05 01:56:47 -08:00
rails_queue_duration_spec.rb Make subscriber tests pass, after refactoring metrics 2017-11-02 18:18:16 +01:00
read_only_spec.rb Allow sidekiq admin requests, regardless of root 2019-01-16 19:14:46 +11:00
release_env_spec.rb Move constants and update for feedback 2018-03-03 00:39:42 +08:00