gitlab-org--gitlab-foss/spec/rubocop/cop/code_reuse/presenter_spec.rb
Yorick Peterse 91c40973dc
Added RuboCop cops to enforce code reuse rules
These Cops enforces the code reuse rules as defined in merge request
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21254.
2018-09-11 15:00:18 +02:00

117 lines
2.7 KiB
Ruby

# frozen_string_literal: true
require 'spec_helper'
require 'rubocop'
require 'rubocop/rspec/support'
require_relative '../../../../rubocop/cop/code_reuse/presenter'
describe RuboCop::Cop::CodeReuse::Presenter do
include CopHelper
subject(:cop) { described_class.new }
it 'flags the use of a Presenter in a Service class' do
allow(cop)
.to receive(:in_service_class?)
.and_return(true)
expect_offense(<<~SOURCE)
class FooService
def execute
FooPresenter.new.execute
^^^^^^^^^^^^^^^^ Presenters can not be used in a Service class.
end
end
SOURCE
end
it 'flags the use of a Presenter in a Finder' do
allow(cop)
.to receive(:in_finder?)
.and_return(true)
expect_offense(<<~SOURCE)
class FooFinder
def execute
FooPresenter.new.execute
^^^^^^^^^^^^^^^^ Presenters can not be used in a Finder.
end
end
SOURCE
end
it 'flags the use of a Service class in a Presenter' do
allow(cop)
.to receive(:in_presenter?)
.and_return(true)
expect_offense(<<~SOURCE)
class FooPresenter
def execute
FooPresenter.new.execute
^^^^^^^^^^^^^^^^ Presenters can not be used in a Presenter.
end
end
SOURCE
end
it 'flags the use of a Presenter in a Serializer' do
allow(cop)
.to receive(:in_serializer?)
.and_return(true)
expect_offense(<<~SOURCE)
class FooSerializer
def execute
FooPresenter.new.execute
^^^^^^^^^^^^^^^^ Presenters can not be used in a Serializer.
end
end
SOURCE
end
it 'flags the use of a Presenter in a model instance method' do
allow(cop)
.to receive(:in_model?)
.and_return(true)
expect_offense(<<~SOURCE)
class User < ActiveRecord::Base
def execute
FooPresenter.new.execute
^^^^^^^^^^^^^^^^ Presenters can not be used in a model.
end
end
SOURCE
end
it 'flags the use of a Presenter in a model class method' do
allow(cop)
.to receive(:in_model?)
.and_return(true)
expect_offense(<<~SOURCE)
class User < ActiveRecord::Base
def self.execute
FooPresenter.new.execute
^^^^^^^^^^^^^^^^ Presenters can not be used in a model.
end
end
SOURCE
end
it 'flags the use of a Presenter in a worker' do
allow(cop)
.to receive(:in_worker?)
.and_return(true)
expect_offense(<<~SOURCE)
class FooWorker
def perform
FooPresenter.new.execute
^^^^^^^^^^^^^^^^ Presenters can not be used in a worker.
end
end
SOURCE
end
end