4012c695cb
Return a non-html-safe, unescaped String instead of ActiveSupport::SafeBuffer to preserve safety when the output is misused. Currently there's oly one user, which does the right thing. Closes #23311
82 lines
2.6 KiB
Ruby
82 lines
2.6 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe EventsHelper do
|
|
describe '#event_note' do
|
|
before do
|
|
allow(helper).to receive(:current_user).and_return(double)
|
|
end
|
|
|
|
it 'displays one line of plain text without alteration' do
|
|
input = 'A short, plain note'
|
|
expect(helper.event_note(input)).to match(input)
|
|
expect(helper.event_note(input)).not_to match(/\.\.\.\z/)
|
|
end
|
|
|
|
it 'displays inline code' do
|
|
input = 'A note with `inline code`'
|
|
expected = 'A note with <code>inline code</code>'
|
|
|
|
expect(helper.event_note(input)).to match(expected)
|
|
end
|
|
|
|
it 'truncates a note with multiple paragraphs' do
|
|
input = "Paragraph 1\n\nParagraph 2"
|
|
expected = 'Paragraph 1...'
|
|
|
|
expect(helper.event_note(input)).to match(expected)
|
|
end
|
|
|
|
it 'displays the first line of a code block' do
|
|
input = "```\nCode block\nwith two lines\n```"
|
|
expected = %r{<pre.+><code>Code block\.\.\.</code></pre>}
|
|
|
|
expect(helper.event_note(input)).to match(expected)
|
|
end
|
|
|
|
it 'truncates a single long line of text' do
|
|
text = 'The quick brown fox jumped over the lazy dog twice' # 50 chars
|
|
input = text * 4
|
|
expected = (text * 2).sub(/.{3}/, '...')
|
|
|
|
expect(helper.event_note(input)).to match(expected)
|
|
end
|
|
|
|
it 'preserves a link href when link text is truncated' do
|
|
text = 'The quick brown fox jumped over the lazy dog' # 44 chars
|
|
input = "#{text}#{text}#{text} " # 133 chars
|
|
link_url = 'http://example.com/foo/bar/baz' # 30 chars
|
|
input << link_url
|
|
expected_link_text = 'http://example...</a>'
|
|
|
|
expect(helper.event_note(input)).to match(link_url)
|
|
expect(helper.event_note(input)).to match(expected_link_text)
|
|
end
|
|
|
|
it 'preserves code color scheme' do
|
|
input = "```ruby\ndef test\n 'hello world'\nend\n```"
|
|
expected = '<pre class="code highlight js-syntax-highlight ruby">' \
|
|
"<code><span class=\"k\">def</span> <span class=\"nf\">test</span>\n" \
|
|
" <span class=\"s1\">\'hello world\'</span>\n" \
|
|
"<span class=\"k\">end</span>\n" \
|
|
'</code></pre>'
|
|
expect(helper.event_note(input)).to eq(expected)
|
|
end
|
|
end
|
|
|
|
describe '#event_commit_title' do
|
|
let(:message) { "foo & bar " + "A" * 70 + "\n" + "B" * 80 }
|
|
subject { helper.event_commit_title(message) }
|
|
|
|
it "returns the first line, truncated to 70 chars" do
|
|
is_expected.to eq(message[0..66] + "...")
|
|
end
|
|
|
|
it "is not html-safe" do
|
|
is_expected.not_to be_a(ActiveSupport::SafeBuffer)
|
|
end
|
|
|
|
it "handles empty strings" do
|
|
expect(helper.event_commit_title("")).to eq("")
|
|
end
|
|
end
|
|
end
|