350e26b8a6
This commits replaces `params` with `safe_params` in `url_for` helpers to resolve security issues [1] and failing specs with the ``` ArgumentError: Attempting to generate a URL from non-sanitized request parameters! An attacker can inject malicious data into the generated URL, such as changing the host. Whitelist and sanitize passed parameters to be secure. ``` error. [1]: https://gitlab.com/gitlab-org/gitlab-ce/issues/45168
87 lines
2.3 KiB
Ruby
87 lines
2.3 KiB
Ruby
class Projects::ApplicationController < ApplicationController
|
|
include RoutableActions
|
|
include ChecksCollaboration
|
|
|
|
skip_before_action :authenticate_user!
|
|
before_action :project
|
|
before_action :repository
|
|
layout 'project'
|
|
|
|
helper_method :repository, :can_collaborate_with_project?, :user_access
|
|
|
|
private
|
|
|
|
def project
|
|
return @project if @project
|
|
return nil unless params[:project_id] || params[:id]
|
|
|
|
path = File.join(params[:namespace_id], params[:project_id] || params[:id])
|
|
auth_proc = ->(project) { !project.pending_delete? }
|
|
|
|
@project = find_routable!(Project, path, extra_authorization_proc: auth_proc)
|
|
end
|
|
|
|
def build_canonical_path(project)
|
|
params[:namespace_id] = project.namespace.to_param
|
|
params[:project_id] = project.to_param
|
|
|
|
url_for(safe_params)
|
|
end
|
|
|
|
def repository
|
|
@repository ||= project.repository
|
|
end
|
|
|
|
def authorize_action!(action)
|
|
unless can?(current_user, action, project)
|
|
return access_denied!
|
|
end
|
|
end
|
|
|
|
def check_project_feature_available!(feature)
|
|
render_404 unless project.feature_available?(feature, current_user)
|
|
end
|
|
|
|
def check_issuables_available!
|
|
render_404 unless project.feature_available?(:issues, current_user) ||
|
|
project.feature_available?(:merge_requests, current_user)
|
|
end
|
|
|
|
def method_missing(method_sym, *arguments, &block)
|
|
case method_sym.to_s
|
|
when /\Aauthorize_(.*)!\z/
|
|
authorize_action!($1.to_sym)
|
|
when /\Acheck_(.*)_available!\z/
|
|
check_project_feature_available!($1.to_sym)
|
|
else
|
|
super
|
|
end
|
|
end
|
|
|
|
def require_non_empty_project
|
|
# Be sure to return status code 303 to avoid a double DELETE:
|
|
# http://api.rubyonrails.org/classes/ActionController/Redirecting.html
|
|
redirect_to project_path(@project), status: 303 if @project.empty_repo?
|
|
end
|
|
|
|
def require_branch_head
|
|
unless @repository.branch_exists?(@ref)
|
|
redirect_to(
|
|
project_tree_path(@project, @ref),
|
|
notice: "This action is not allowed unless you are on a branch"
|
|
)
|
|
end
|
|
end
|
|
|
|
def apply_diff_view_cookie!
|
|
cookies.permanent[:diff_view] = params.delete(:view) if params[:view].present?
|
|
end
|
|
|
|
def require_pages_enabled!
|
|
not_found unless @project.pages_available?
|
|
end
|
|
|
|
def check_issues_available!
|
|
return render_404 unless @project.feature_available?(:issues, current_user)
|
|
end
|
|
end
|