kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/app/helpers
History
Dmitriy Zaporozhets 16db51ec58 Merge branch 'fix-wiki-search' into 'master' 
Fix Error 500 when searching Wiki pages

If a Wiki page turns up a hit in the search results, an error will occur:

```
Completed 500 Internal Server Error in 836ms

NoMethodError - undefined method `slug' for "test.markdown":String:
  app/helpers/wiki_helper.rb:10:in `namespace_project_wiki_path'
  app/views/search/results/_wiki_blob.html.haml:4:in `_app_views_search_results__wiki_blob_html_haml___2752621660395393333_70299911622700'
  actionview (4.1.9) lib/action_view/template.rb:145:in `block in render'
  activesupport (4.1.9) lib/active_support/notifications.rb:161:in `instrument'
  actionview (4.1.9) lib/action_view/template.rb:339:in `instrument'
  actionview (4.1.9) lib/action_view/template.rb:143:in `render'
```

An unhandled String containing the name of the Wiki page would be provided to the URL path generator. This MR handles that case.

Closes #1547

See merge request !592
 		2015-05-04 08:53:21 +00:00
..
appearances_helper.rb Get rid of black logo 2015-02-24 23:17:11 -08:00
application_helper.rb Add helpers for header title and sidebar, and move setting those from controllers to layouts. 2015-05-01 10:39:16 +02:00
application_settings_helper.rb More restricted visibility changes 2015-03-10 18:36:43 -06:00
blob_helper.rb Improve file icons rendering on tree 2015-03-28 16:49:05 +01:00
branches_helper.rb Refactor GitAccess to use instance variables. 2015-03-24 14:11:48 +01:00
broadcast_messages_helper.rb
…
commits_helper.rb Add Commit#author and #committer. 2015-04-02 10:57:01 +02:00
compare_helper.rb Upgrade to Rails 4.1.9 2015-02-14 11:09:23 -07:00
dashboard_helper.rb Add project filter by visibility and tag to explore page 2015-03-10 15:59:14 -07:00
diff_helper.rb Fix "Revspec not found" errors when viewing diffs in a forked project with submodules 2015-04-27 20:42:38 -07:00
emails_helper.rb Revert "Merge branch 'fix_email_images' into 'master'" 2015-04-13 12:34:47 +02:00
events_helper.rb List new commits for newly pushed branch in activity view. 2015-03-18 14:28:50 +01:00
explore_helper.rb Add project filter by visibility and tag to explore page 2015-03-10 15:59:14 -07:00
external_wiki_helper.rb Add a service to support external wikis 2015-03-12 19:13:51 +01:00
git_helper.rb
…
gitlab_markdown_helper.rb Add Gitlab::Markdown::SanitizationFilter 2015-04-30 16:35:25 -04:00
gitlab_routing_helper.rb Better looking milestone lists 2015-04-01 02:45:47 +03:00
graph_helper.rb
…
groups_helper.rb Add a page title to every page. 2015-04-30 19:12:15 +02:00
icons_helper.rb Check symlink mode as a String for file_type_icon_class 2015-04-01 23:34:33 -04:00
issues_helper.rb Remove title_for_issue helper 2015-04-30 17:27:33 -04:00
labels_helper.rb Escape title attributes in references 2015-04-20 13:01:46 -04:00
merge_requests_helper.rb Style/RedundantReturn enabled 2015-03-24 18:35:57 -07:00
milestones_helper.rb Group milestones by title in the dashboard and all other issue views 2015-05-01 01:12:58 +02:00
namespaces_helper.rb Prevent database query each time we render group avatar 2015-03-12 13:56:53 -07:00
nav_helper.rb Fix toggle of sidebar 2015-04-22 16:48:39 +03:00
notes_helper.rb Fix bug where editing a comment with "+1" or "-1" would cause a server error 2015-03-02 15:26:00 -08:00
notifications_helper.rb
…
oauth_helper.rb Restyle oauth accounts at profile page and add ability to unlink account 2015-03-21 17:46:00 -07:00
page_layout_helper.rb Add helpers for header title and sidebar, and move setting those from controllers to layouts. 2015-05-01 10:39:16 +02:00
profile_helper.rb Restyle oauth accounts at profile page and add ability to unlink account 2015-03-21 17:46:00 -07:00
projects_helper.rb Add a page title to every page. 2015-04-30 19:12:15 +02:00
search_helper.rb Update views to single form of address. Change "my" to "your" 2015-03-22 20:10:12 -07:00
selects_helper.rb Let members be invited from Add members pane. 2015-04-14 12:08:10 +02:00
snippets_helper.rb Upgrade to Rails 4.1.9 2015-02-14 11:09:23 -07:00
sorting_helper.rb Refactor sorting in project 2015-02-05 19:15:05 -08:00
submodule_helper.rb Fix "Revspec not found" errors when viewing diffs in a forked project with submodules 2015-04-27 20:42:38 -07:00
tab_helper.rb Use `project_member` instead of `team_member`. 2015-03-15 13:50:38 +01:00
tags_helper.rb
…
tree_helper.rb Improve file icons rendering on tree 2015-03-28 16:49:05 +01:00
visibility_level_helper.rb Add period at snippet visibilty description 2015-05-03 15:00:46 +02:00
wiki_helper.rb Fix Error 500 when searching Wiki pages 2015-04-30 08:54:08 -07:00