gitlab-org--gitlab-foss/spec/rubocop/cop/put_group_routes_under_scop...

61 lines
1.6 KiB
Ruby

# frozen_string_literal: true
require 'fast_spec_helper'
require_relative '../../../rubocop/cop/put_group_routes_under_scope'
RSpec.describe RuboCop::Cop::PutGroupRoutesUnderScope do
subject(:cop) { described_class.new }
%w[resource resources get post put patch delete].each do |route_method|
it "registers an offense when route is outside scope for `#{route_method}`" do
offense = "#{route_method} :notes"
marker = '^' * offense.size
expect_offense(<<~PATTERN)
scope(path: 'groups/*group_id/-', module: :groups) do
resource :issues
end
#{offense}
#{marker} Put new group routes under /-/ scope
PATTERN
end
end
it 'does not register an offense when resource inside the scope' do
expect_no_offenses(<<~PATTERN)
scope(path: 'groups/*group_id/-', module: :groups) do
resource :issues
resource :notes
end
PATTERN
end
it 'does not register an offense when resource is deep inside the scope' do
expect_no_offenses(<<~PATTERN)
scope(path: 'groups/*group_id/-', module: :groups) do
resource :issues
resource :projects do
resource :issues do
resource :notes
end
end
end
PATTERN
end
it 'does not register an offense for the root route' do
expect_no_offenses(<<~PATTERN)
get '/'
PATTERN
end
it 'does not register an offense for the root route within scope' do
expect_no_offenses(<<~PATTERN)
scope(path: 'groups/*group_id/-', module: :groups) do
get '/'
end
PATTERN
end
end