239743345a
Due to autoloading and Ruby scoping, the .update file was never being updated due to this error: ``` NoMethodError: undefined method `pages' for Projects::Settings:Module from /opt/gitlab/embedded/service/gitlab-rails/app/services/projects/update_pages_configuration_service.rb:50:in `pages_update_file' from /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/metrics/instrumentation.rb:157:in `pages_update_file' from (irb):6 from /opt/gitlab/embedded/lib/ruby/gems/2.3.0/gems/railties-4.2.7.1/lib/rails/commands/console.rb:110:in `start' from /opt/gitlab/embedded/lib/ruby/gems/2.3.0/gems/railties-4.2.7.1/lib/rails/commands/console.rb:9:in `start' from /opt/gitlab/embedded/lib/ruby/gems/2.3.0/gems/railties-4.2.7.1/lib/rails/commands/commands_tasks.rb:68:in `console' from /opt/gitlab/embedded/lib/ruby/gems/2.3.0/gems/railties-4.2.7.1/lib/rails/commands/commands_tasks.rb:39:in `run_command!' from /opt/gitlab/embedded/lib/ruby/gems/2.3.0/gems/railties-4.2.7.1/lib/rails/commands.rb:17:in `<top (required)>' from bin/rails:9:in `require' ``` This error was caught and discarded quietly. This fix exercises this code and fixes the scope problem. Closes gitlab-com/infrastructure#1058 |
||
---|---|---|
.. | ||
auth | ||
boards | ||
chat_names | ||
ci | ||
discussions | ||
files | ||
groups | ||
issuable | ||
issues | ||
labels | ||
members | ||
merge_requests | ||
milestones | ||
notes | ||
projects | ||
protected_branches | ||
search | ||
slash_commands | ||
users | ||
access_token_validation_service_spec.rb | ||
after_branch_delete_service_spec.rb | ||
compare_service_spec.rb | ||
create_deployment_service_spec.rb | ||
create_release_service_spec.rb | ||
create_snippet_service_spec.rb | ||
create_tag_service_spec.rb | ||
delete_branch_service_spec.rb | ||
delete_merged_branches_service_spec.rb | ||
delete_tag_service_spec.rb | ||
delete_user_service_spec.rb | ||
destroy_group_service_spec.rb | ||
event_create_service_spec.rb | ||
git_hooks_service_spec.rb | ||
git_push_service_spec.rb | ||
git_tag_push_service_spec.rb | ||
import_export_clean_up_service_spec.rb | ||
notification_service_spec.rb | ||
pages_service_spec.rb | ||
repair_ldap_blocked_user_service_spec.rb | ||
repository_archive_clean_up_service_spec.rb | ||
search_service_spec.rb | ||
system_hooks_service_spec.rb | ||
system_note_service_spec.rb | ||
test_hook_service_spec.rb | ||
todo_service_spec.rb | ||
update_release_service_spec.rb | ||
update_snippet_service_spec.rb | ||
user_project_access_changed_service_spec.rb |