6f3c490107
This refactors the AutocompleteController according to the guidelines and boundaries discussed in https://gitlab.com/gitlab-org/gitlab-ce/issues/49653. Specifically, ActiveRecord logic is moved to different finders, which are then used in the controller. View logic in turn is moved to presenters, instead of directly using ActiveRecord's "to_json" method. The finder MoveToProjectFinder is also adjusted according to the abstraction guidelines and boundaries, resulting in a much more simple finder. By using finders (and other abstractions) more actively, we can push a lot of logic out of the controller. We also remove the need for various "before_action" hooks, though this could be achieved without using finders as well. The various finders related to AutcompleteController have also been moved into a namespace. This removes the need for calling everything "AutocompleteSmurfFinder", instead you can use "Autocomplete::SmurfFinder".
44 lines
1,015 B
Ruby
44 lines
1,015 B
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
describe OptionallySearch do
|
|
let(:model) do
|
|
Class.new(ActiveRecord::Base) do
|
|
self.table_name = 'users'
|
|
|
|
include OptionallySearch
|
|
end
|
|
end
|
|
|
|
describe '.search' do
|
|
it 'raises NotImplementedError' do
|
|
expect { model.search('foo') }.to raise_error(NotImplementedError)
|
|
end
|
|
end
|
|
|
|
describe '.optionally_search' do
|
|
context 'when a query is given' do
|
|
it 'delegates to the search method' do
|
|
expect(model)
|
|
.to receive(:search)
|
|
.with('foo')
|
|
|
|
model.optionally_search('foo')
|
|
end
|
|
end
|
|
|
|
context 'when no query is given' do
|
|
it 'returns the current relation' do
|
|
expect(model.optionally_search).to be_a_kind_of(ActiveRecord::Relation)
|
|
end
|
|
end
|
|
|
|
context 'when an empty query is given' do
|
|
it 'returns the current relation' do
|
|
expect(model.optionally_search(''))
|
|
.to be_a_kind_of(ActiveRecord::Relation)
|
|
end
|
|
end
|
|
end
|
|
end
|