gitlab-org--gitlab-foss/app/controllers/groups/variables_controller.rb
gfyoung be42c05054 Enable more frozen string in app/controllers/
Enables frozen string for the following:

* app/controllers/dashboard/**/*.rb
* app/controllers/explore/**/*.rb
* app/controllers/google_api/**/*.rb
* app/controllers/groups/**/*.rb
* app/controllers/import/**/*.rb
* app/controllers/instance_statistics/**/*.rb
* app/controllers/ldap/**/*.rb
* app/controllers/oauth/**/*.rb
* app/controllers/profiles/**/*.rb

Partially addresses #47424.
2018-09-23 12:48:02 -07:00

51 lines
1.2 KiB
Ruby

# frozen_string_literal: true
module Groups
class VariablesController < Groups::ApplicationController
before_action :authorize_admin_build!
skip_cross_project_access_check :show, :update
def show
respond_to do |format|
format.json do
render status: :ok, json: { variables: GroupVariableSerializer.new.represent(@group.variables) }
end
end
end
def update
if @group.update(group_variables_params)
respond_to do |format|
format.json { render_group_variables }
end
else
respond_to do |format|
format.json { render_error }
end
end
end
private
def render_group_variables
render status: :ok, json: { variables: GroupVariableSerializer.new.represent(@group.variables) }
end
def render_error
render status: :bad_request, json: @group.errors.full_messages
end
def group_variables_params
params.permit(variables_attributes: [*variable_params_attributes])
end
def variable_params_attributes
%i[id key secret_value protected _destroy]
end
def authorize_admin_build!
return render_404 unless can?(current_user, :admin_build, group)
end
end
end