ac702af822
Prior to this commit running Namespace#force_share_with_group_lock_on_descendants would result in updating _all_ namespaces in the namespaces table, not just the descendants. This is the result of ActiveRecord::Relation#update_all not taking into account the CTE. To work around this we use the CTE query as a sub-query instead of directly calling #update_all. To prevent this from happening the relations returned by Gitlab::GroupHierarchy are now marked as read-only, resulting in an error being raised when methods such as #update_all are used. Fortunately on GitLab.com our statement timeouts appear to have prevented this query from actually doing any damage other than causing a very large amount of dead tuples. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/37916
92 lines
2.7 KiB
Ruby
92 lines
2.7 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe Gitlab::GroupHierarchy, :postgresql do
|
|
let!(:parent) { create(:group) }
|
|
let!(:child1) { create(:group, parent: parent) }
|
|
let!(:child2) { create(:group, parent: child1) }
|
|
|
|
describe '#base_and_ancestors' do
|
|
let(:relation) do
|
|
described_class.new(Group.where(id: child2.id)).base_and_ancestors
|
|
end
|
|
|
|
it 'includes the base rows' do
|
|
expect(relation).to include(child2)
|
|
end
|
|
|
|
it 'includes all of the ancestors' do
|
|
expect(relation).to include(parent, child1)
|
|
end
|
|
|
|
it 'uses ancestors_base #initialize argument' do
|
|
relation = described_class.new(Group.where(id: child2.id), Group.none).base_and_ancestors
|
|
|
|
expect(relation).to include(parent, child1, child2)
|
|
end
|
|
|
|
it 'does not allow the use of #update_all' do
|
|
expect { relation.update_all(share_with_group_lock: false) }
|
|
.to raise_error(ActiveRecord::ReadOnlyRecord)
|
|
end
|
|
end
|
|
|
|
describe '#base_and_descendants' do
|
|
let(:relation) do
|
|
described_class.new(Group.where(id: parent.id)).base_and_descendants
|
|
end
|
|
|
|
it 'includes the base rows' do
|
|
expect(relation).to include(parent)
|
|
end
|
|
|
|
it 'includes all the descendants' do
|
|
expect(relation).to include(child1, child2)
|
|
end
|
|
|
|
it 'uses descendants_base #initialize argument' do
|
|
relation = described_class.new(Group.none, Group.where(id: parent.id)).base_and_descendants
|
|
|
|
expect(relation).to include(parent, child1, child2)
|
|
end
|
|
|
|
it 'does not allow the use of #update_all' do
|
|
expect { relation.update_all(share_with_group_lock: false) }
|
|
.to raise_error(ActiveRecord::ReadOnlyRecord)
|
|
end
|
|
end
|
|
|
|
describe '#all_groups' do
|
|
let(:relation) do
|
|
described_class.new(Group.where(id: child1.id)).all_groups
|
|
end
|
|
|
|
it 'includes the base rows' do
|
|
expect(relation).to include(child1)
|
|
end
|
|
|
|
it 'includes the ancestors' do
|
|
expect(relation).to include(parent)
|
|
end
|
|
|
|
it 'includes the descendants' do
|
|
expect(relation).to include(child2)
|
|
end
|
|
|
|
it 'uses ancestors_base #initialize argument for ancestors' do
|
|
relation = described_class.new(Group.where(id: child1.id), Group.where(id: Group.maximum(:id).succ)).all_groups
|
|
|
|
expect(relation).to include(parent)
|
|
end
|
|
|
|
it 'uses descendants_base #initialize argument for descendants' do
|
|
relation = described_class.new(Group.where(id: Group.maximum(:id).succ), Group.where(id: child1.id)).all_groups
|
|
|
|
expect(relation).to include(child2)
|
|
end
|
|
|
|
it 'does not allow the use of #update_all' do
|
|
expect { relation.update_all(share_with_group_lock: false) }
|
|
.to raise_error(ActiveRecord::ReadOnlyRecord)
|
|
end
|
|
end
|
|
end
|