bc13cd7a9b
Resolve "Inconsistency: Repo Title "down caret" cropped on smaller viewports" ## What does this MR do? Fixes an issue where the dropdown chevron for a project list was not visible on smaller viewports. This MR also changes the dropdown trigger into a `button` element for better accessibility (it can now be tabbed to like any link). ## Are there points in the code the reviewer needs to double check? None that I can think of. ## Why was this MR needed? Better accessibility and support for smaller viewports. ## Screenshots (if relevant) Dropdown toggle now targetable by pressing tab to select. ![Screen_Shot_2016-08-31_at_9.12.15_PM](/uploads/8b2038a8ae259efd32da2e94a309ce88/Screen_Shot_2016-08-31_at_9.12.15_PM.png) Chevron no longer hidden when project title length triggers `overflow: ellipsis`. ![Screen_Shot_2016-08-31_at_9.13.38_PM](/uploads/382e76c06e54bc307106a84ec21ab892/Screen_Shot_2016-08-31_at_9.13.38_PM.png) ## Does this MR meet the acceptance criteria? - [x] CHANGELOG entry added - Tests - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #21506 See merge request !6140 |
||
---|---|---|
.. | ||
appearances_helper.rb | ||
application_helper.rb | ||
application_settings_helper.rb | ||
auth_helper.rb | ||
avatars_helper.rb | ||
blob_helper.rb | ||
branches_helper.rb | ||
broadcast_messages_helper.rb | ||
button_helper.rb | ||
ci_status_helper.rb | ||
commits_helper.rb | ||
compare_helper.rb | ||
dashboard_helper.rb | ||
diff_helper.rb | ||
dropdowns_helper.rb | ||
emails_helper.rb | ||
events_helper.rb | ||
explore_helper.rb | ||
external_wiki_helper.rb | ||
form_helper.rb | ||
git_helper.rb | ||
gitlab_markdown_helper.rb | ||
gitlab_routing_helper.rb | ||
graph_helper.rb | ||
groups_helper.rb | ||
icons_helper.rb | ||
import_helper.rb | ||
issuables_helper.rb | ||
issues_helper.rb | ||
javascript_helper.rb | ||
kerberos_spnego_helper.rb | ||
labels_helper.rb | ||
lfs_helper.rb | ||
members_helper.rb | ||
merge_requests_helper.rb | ||
milestones_helper.rb | ||
namespaces_helper.rb | ||
nav_helper.rb | ||
notes_helper.rb | ||
notifications_helper.rb | ||
page_layout_helper.rb | ||
preferences_helper.rb | ||
projects_helper.rb | ||
runners_helper.rb | ||
search_helper.rb | ||
selects_helper.rb | ||
sentry_helper.rb | ||
services_helper.rb | ||
snippets_helper.rb | ||
sorting_helper.rb | ||
submodule_helper.rb | ||
tab_helper.rb | ||
tags_helper.rb | ||
time_helper.rb | ||
todos_helper.rb | ||
tree_helper.rb | ||
triggers_helper.rb | ||
u2f_helper.rb | ||
version_check_helper.rb | ||
visibility_level_helper.rb | ||
workhorse_helper.rb |