kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/app/assets/javascripts
History
Alfredo Sumaran 052480ae53 Merge branch 'replace-jquery-cookie-plugin' into 'master' 
Replace jquery-cookie plugin with js-cookie

## What does this MR do?

Removes an outdated and unmaintained dependency [jquery.cookie](https://github.com/carhartl/jquery-cookie) with its successor [js.cookie](https://github.com/js-cookie/js-cookie) which is not dependent on jQuery.

Also this MR adds a global default cookie `path` setting which defaults to the GitLab root directory.  Now, setting a cookie to any path other than `gon.relative_url_root` requires an explicit opt-out.  This is a sensible default and should prevent accidental omission going forward.

## Are there points in the code the reviewer needs to double check?

Double check that all instances of `$.cookie(x)` have been replaced by `Cookies.get(x)` and all instances of `$.cookie(x, y, z)` are replaced with `Cookies.set(x, y, z)`.  All javascripts which set or retrieve cookie values should function just as before.

## Why was this MR needed?

One more step toward shaking off jQuery as a dependency (#23022), also [jquery.cookie](https://github.com/carhartl/jquery-cookie) is no longer maintained and hasn't seen an update in 2+ years.

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- Tests
  - [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

#23022

See merge request !7085
2016-10-26 01:28:10 +00:00
..
behaviors Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00
blob Removed append logic 2016-10-21 21:53:10 +01:00
blob_edit Make fixes to get tests passing. 2016-10-05 11:25:05 +02:00
boards replace jquery.cookie vendor script with js.cookie 2016-10-24 18:09:00 -05:00
commit Formatted all app/assets/javascripts to underscore naming convention 2016-10-10 17:09:48 +01:00
diff_notes Pass the full project path for resolve buttons 2016-09-21 10:07:24 +01:00
extensions converted last method to jQuery 2016-10-20 22:18:39 +01:00
graphs Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00
lib Close any open tooltips before page:fetch 2016-10-20 21:01:37 +02:00
merge_conflicts remove manual Cookie.set "path" option in favor of global setting 2016-10-24 18:09:00 -05:00
network Formatted all app/assets/javascripts to underscore naming convention 2016-10-10 17:09:48 +01:00
profile Fix profile test failure. 2016-10-05 11:25:05 +02:00
protected_branches Create protected branches bundle 2016-10-20 12:03:30 -05:00
snippet
templates Removed append logic 2016-10-21 21:53:10 +01:00
u2f Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00
users Replace contributions calendar timezone payload with dates 2016-09-16 14:38:59 -05:00
abuse_reports.js.es6
activities.js remove manual Cookie.set "path" option in favor of global setting 2016-10-24 18:09:00 -05:00
admin.js
api.js Create a new /templates API namespace 2016-10-12 11:09:41 +02:00
application.js Merge branch 'replace-jquery-cookie-plugin' into 'master' 2016-10-26 01:28:10 +00:00
aside.js
autosave.js Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00
awards_handler.js remove manual Cookie.set "path" option in favor of global setting 2016-10-24 18:09:00 -05:00
breakpoints.js Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00
broadcast_message.js
build.js Replaced deprecated use of document.body.scrollTop 2016-10-24 12:56:22 -05:00
build_artifacts.js
build_variables.js.es6
commit.js
commits.js Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00
compare.js
compare_autocomplete.js.es6 Added logic to handle a revision input that does not exist in the menu 2016-10-16 20:02:16 -07:00
confirm_danger_modal.js
copy_to_clipboard.js Fix tooltip for Copy to clipboard button. 2016-09-29 21:48:11 -05:00
create_label.js.es6 Convert label creation from API to controller endpoint 2016-09-23 12:21:47 +01:00
cycle_analytics.js.es6 remove manual Cookie.set "path" option in favor of global setting 2016-10-24 18:09:00 -05:00
diff.js ensure the 'fixed layout' preference is honored whenever possible 2016-09-20 00:51:00 -05:00
dispatcher.js.es6 invoked the pipelines class when builds are dynamically loaded and dispatched for commit builds page 2016-10-24 13:20:37 -05:00
dropzone_input.js
due_date_select.js.es6 Convert due_date_select.js filetype to es6. 2016-10-17 11:58:03 +02:00
files_comment_button.js
flash.js
gfm_auto_complete.js.es6 Debounce GfmAutoComplete setup and simplify code somewhat. 2016-10-07 18:07:55 +02:00
gl_dropdown.js Fixed undefined keycode build error 2016-10-14 09:34:53 +01:00
gl_field_errors.js.es6 Stop injecting field errors where they won't be used. 2016-10-20 11:31:03 +02:00
gl_form.js Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00
group_avatar.js
groups_select.js fix group links 404 2016-10-05 09:57:54 +01:00
importer_status.js fix indent in JS file 2016-09-20 12:10:35 +02:00
issuable.js.es6 Ensure search val is defined. 2016-10-25 12:46:28 +02:00
issuable_context.js
issuable_form.js
issue.js Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00
issue_status_select.js
issues_bulk_assignment.js.es6 Formatted all app/assets/javascripts to underscore naming convention 2016-10-10 17:09:48 +01:00
label_manager.js.es6 Formatted all app/assets/javascripts to underscore naming convention 2016-10-10 17:09:48 +01:00
labels.js Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00
labels_select.js Return the title for id of 'No label' 2016-10-19 04:55:26 +01:00
layout_nav.js Doesnt run JS if active element doesnt exist 2016-09-16 13:52:06 +01:00
line_highlighter.js Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00
logo.js
member_expiration_date.js Updates the member row when values changed 2016-09-13 08:44:59 +01:00
members.js.es6 Refactor js that disable form submit if no members selected 2016-10-24 13:14:00 +03:00
merge_request.js ensure the 'fixed layout' preference is honored whenever possible 2016-09-20 00:51:00 -05:00
merge_request_tabs.js replace jquery.cookie vendor script with js.cookie 2016-10-24 18:09:00 -05:00
merge_request_widget.js.es6 Updates class name for consistency 2016-10-17 22:10:43 +01:00
merged_buttons.js
milestone.js Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00
milestone_select.js Updated JS to work with issue index & show 2016-10-12 17:43:20 +01:00
namespace_select.js
new_branch_form.js
new_commit_form.js
notes.js Changed props to use strings 2016-09-21 10:19:47 +01:00
notifications_dropdown.js
notifications_form.js
pager.js
pipelines.js.es6 converted last method to jQuery 2016-10-20 22:18:39 +01:00
preview_markdown.js Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00
project.js remove manual Cookie.set "path" option in favor of global setting 2016-10-24 18:09:00 -05:00
project_avatar.js
project_find_file.js Fixed find file keyboard navigation 2016-10-17 16:55:34 +01:00
project_fork.js
project_import.js
project_new.js Add visibility level to project repository 2016-10-17 18:12:18 -02:00
project_select.js fix group links 404 2016-10-05 09:57:54 +01:00
project_show.js Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00
projects_list.js Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00
right_sidebar.js remove manual Cookie.set "path" option in favor of global setting 2016-10-24 18:09:00 -05:00
search.js fix group links 404 2016-10-05 09:57:54 +01:00
search_autocomplete.js.es6 Refactor IssuesBulkAssignment to ES6. 2016-10-05 11:25:03 +02:00
shortcuts.js Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00
shortcuts_blob.js
shortcuts_dashboard_navigation.js
shortcuts_find_file.js Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00
shortcuts_issuable.js Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00
shortcuts_navigation.js Added keyboard shortcut to navigate to issue boards 2016-09-15 18:20:36 -04:00
shortcuts_network.js
sidebar.js.es6 remove manual Cookie.set "path" option in favor of global setting 2016-10-24 18:09:00 -05:00
single_file_diff.js
snippets_list.js.es6
star.js
subscription.js
subscription_select.js
syntax_highlight.js Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00
todos.js.es6 Make fixes to get tests passing. 2016-10-05 11:25:05 +02:00
tree.js Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00
user.js.es6 remove manual Cookie.set "path" option in favor of global setting 2016-10-24 18:09:00 -05:00
user_tabs.js.es6 Change user & group landing page routing from /u/:name & /groups/:name to /:name 2016-10-06 19:50:48 +03:00
username_validator.js.es6 Update endpoint to username validator 2016-10-17 17:47:07 -05:00
users_select.js Validate user id for users select autcomplete 2016-10-14 16:04:23 +03:00
wikis.js
zen_mode.js Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00