gitlab-org--gitlab-foss/spec/javascripts
Alfredo Sumaran 052480ae53 Merge branch 'replace-jquery-cookie-plugin' into 'master'
Replace jquery-cookie plugin with js-cookie

## What does this MR do?

Removes an outdated and unmaintained dependency [jquery.cookie](https://github.com/carhartl/jquery-cookie) with its successor [js.cookie](https://github.com/js-cookie/js-cookie) which is not dependent on jQuery.

Also this MR adds a global default cookie `path` setting which defaults to the GitLab root directory.  Now, setting a cookie to any path other than `gon.relative_url_root` requires an explicit opt-out.  This is a sensible default and should prevent accidental omission going forward.

## Are there points in the code the reviewer needs to double check?

Double check that all instances of `$.cookie(x)` have been replaced by `Cookies.get(x)` and all instances of `$.cookie(x, y, z)` are replaced with `Cookies.set(x, y, z)`.  All javascripts which set or retrieve cookie values should function just as before.

## Why was this MR needed?

One more step toward shaking off jQuery as a dependency (#23022), also [jquery.cookie](https://github.com/carhartl/jquery-cookie) is no longer maintained and hasn't seen an update in 2+ years.

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- Tests
  - [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

#23022

See merge request !7085
2016-10-26 01:28:10 +00:00
..
behaviors Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00
boards replace jquery.cookie vendor script with js.cookie 2016-10-24 18:09:00 -05:00
extensions ES6ify all the things! 2016-07-24 23:45:11 +03:00
fixtures Add tests for gl_field_errors. 2016-10-15 08:28:52 +02:00
graphs Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00
u2f Make UX upgrades to SignIn/Register views. 2016-10-15 08:27:21 +02:00
abuse_reports_spec.js.es6 Some more styling tweaks and added jasmine test 2016-08-14 00:54:18 +01:00
activities_spec.js.es6 replace jquery.cookie vendor script with js.cookie 2016-10-24 18:09:00 -05:00
application_spec.js Check for existence of elements under test in application_spec.js (!6051) 2016-08-26 10:57:59 +02:00
awards_handler_spec.js remove manual Cookie.set "path" option in favor of global setting 2016-10-24 18:09:00 -05:00
datetime_utility_spec.js.es6 Convert datetime coffeescript spec to ES6 2016-09-01 21:09:47 -05:00
diff_comments_store_spec.js.es6 Fixed issue with expand diff not initializing resolve buttons 2016-08-04 11:27:11 +01:00
gl_dropdown_spec.js.es6 Fixed conflicts 2016-08-18 23:46:23 +01:00
gl_field_errors_spec.js.es6 Update gl_field_error tests for better input filtering. 2016-10-20 12:47:32 +02:00
issue_spec.js Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00
labels_issue_sidebar_spec.js.es6 Send ajax request for label update only if they are changed (#19472 !5071) 2016-09-27 10:23:15 -05:00
line_highlighter_spec.js ES6ify all the things! 2016-07-24 23:45:11 +03:00
merge_request_spec.js ES6ify all the things! 2016-07-24 23:45:11 +03:00
merge_request_tabs_spec.js Fixed merge request tab JS spec 2016-10-06 10:17:34 +01:00
merge_request_widget_spec.js Fixed conflict and corrected teaspoon test 2016-10-14 11:07:01 +02:00
new_branch_spec.js Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00
notes_spec.js Add textarea autoresize after comment 2016-09-01 13:57:07 -05:00
project_title_spec.js Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00
right_sidebar_spec.js replace jquery.cookie vendor script with js.cookie 2016-10-24 18:09:00 -05:00
search_autocomplete_spec.js Prevent conflict b/w search field and its dropdown 2016-10-10 10:16:09 +02:00
shortcuts_issuable_spec.js Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00
spec_helper.js Require comments must be included before code 2016-09-08 14:07:27 -05:00
syntax_highlight_spec.js ES6ify all the things! 2016-07-24 23:45:11 +03:00
zen_mode_spec.js Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00