gitlab-org--gitlab-foss/features/steps
Dmitriy Zaporozhets 541f7675f9 Merge branch 'fix-diff-patch-public-mr' into 'master'
Fix downloading of patches on public merge requests when user logged out

### What does this MR do?

This MR makes it possible to download a diff patch on a public merge request when a user is logged out.

### Why was this MR needed?

An Error 500 would result when a user attempted to click on the "Email Patches" or "Plain Diff" button:

```
NoMethodError - undefined method `id' for nil:NilClass:
  lib/gitlab/backend/shell_env.rb:9:in `set_env'
  lib/gitlab/satellite/action.rb:20:in `in_locked_and_timed_satellite'
  lib/gitlab/satellite/merge_action.rb:49:in `diff_in_satellite'
  app/models/merge_request.rb:219:in `to_diff'
  app/controllers/projects/merge_requests_controller.rb:42:in `block (2 levels) in show'
```

### What are the relevant issue numbers?

* Closes #1225
* Closes #1854 (dup)
* Closes #1858 (dup)

See merge request !872
2015-06-23 15:03:00 +00:00
..
admin Fix tests for admin identities after migrate to rspec3 2015-06-23 15:49:15 +02:00
dashboard Merge branch 'master' into rubocop-for-tests 2015-06-23 10:44:03 +02:00
explore Fix rubocop issues at feature/ directory 2015-06-22 14:21:34 +02:00
profile Fix avatar tests to use banana_sample.gif since SVG is not supported 2015-06-22 12:04:07 -07:00
project Fix downloading of patches on public merge requests when user logged out 2015-06-23 05:34:21 -07:00
shared Fix downloading of patches on public merge requests when user logged out 2015-06-23 05:34:21 -07:00
snippets Fix rubocop issues at feature/ directory 2015-06-22 14:21:34 +02:00
groups.rb Fix avatar tests to use banana_sample.gif since SVG is not supported 2015-06-22 12:04:07 -07:00
invites.rb Add spinach tests around accepting and declining invitations. 2015-04-14 18:04:29 +02:00
search.rb Fix features syntax 2015-06-22 12:13:45 +02:00
snippet_search.rb Update all `should`-style syntax to `expect` in features 2015-06-12 05:12:09 -04:00
user.rb Change `within` to `page.within` in feature steps 2015-06-12 05:12:42 -04:00