6d37fe952b
Fix missing access checks on issue lookup using IssuableFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867 ⚠️ - Potentially untested 💣 - No test coverage 🚥 - Test coverage of some sort exists (a test failed when error raised) 🚦 - Test coverage of return value (a test failed when nil used) ✅ - Permissions check tested - [x] ✅ app/controllers/projects/branches_controller.rb:39 - `before_action :authorize_push_code!` helpes limit/prevent exploitation. Always checks for reporter access so fine with confidential issues, issues only visible to team, etc. - [x] 🚥 app/models/cycle_analytics/summary.rb:9 [`.count`] - [x] ✅ app/controllers/projects/todos_controller.rb:19 - [x] Potential double render in app/controllers/projects/todos_controller.rb - https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#cedccb227af9bfdf88802767cb58d43c2b977439_24_24 See merge request !2030
33 lines
1.2 KiB
Ruby
33 lines
1.2 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe 'CycleAnalytics#review', feature: true do
|
|
extend CycleAnalyticsHelpers::TestGeneration
|
|
|
|
let(:project) { create(:project) }
|
|
let(:from_date) { 10.days.ago }
|
|
let(:user) { create(:user, :admin) }
|
|
subject { CycleAnalytics.new(project, user, from: from_date) }
|
|
|
|
generate_cycle_analytics_spec(
|
|
phase: :review,
|
|
data_fn: -> (context) { { issue: context.create(:issue, project: context.project) } },
|
|
start_time_conditions: [["merge request that closes issue is created",
|
|
-> (context, data) do
|
|
context.create_merge_request_closing_issue(data[:issue])
|
|
end]],
|
|
end_time_conditions: [["merge request that closes issue is merged",
|
|
-> (context, data) do
|
|
context.merge_merge_requests_closing_issue(data[:issue])
|
|
end]],
|
|
post_fn: nil)
|
|
|
|
context "when a regular merge request (that doesn't close the issue) is created and merged" do
|
|
it "returns nil" do
|
|
5.times do
|
|
MergeRequests::MergeService.new(project, user).execute(create(:merge_request))
|
|
end
|
|
|
|
expect(subject.review).to be_nil
|
|
end
|
|
end
|
|
end
|