57b96eb6db
This ensures the open issues/MR count caches are refreshed properly when creating new issues or MRs. This MR also includes a change to the cache keys to ensure all caches are rebuilt on the fly. This particular problem was not caught in the test suite due to a null cache being used, resulting in all calls that would use a cache using the underlying data directly. In production the code would fail because a newly saved record returns an empty hash in #changes meaning checks such as `state_changed? || confidential_changed?` would return false for new rows, thus never updating the counters. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/38061
44 lines
1.6 KiB
Ruby
44 lines
1.6 KiB
Ruby
module Issues
|
|
class CloseService < Issues::BaseService
|
|
# Closes the supplied issue if the current user is able to do so.
|
|
def execute(issue, commit: nil, notifications: true, system_note: true)
|
|
return issue unless can?(current_user, :update_issue, issue)
|
|
|
|
close_issue(issue,
|
|
commit: commit,
|
|
notifications: notifications,
|
|
system_note: system_note)
|
|
end
|
|
|
|
# Closes the supplied issue without checking if the user is authorized to
|
|
# do so.
|
|
#
|
|
# The code calling this method is responsible for ensuring that a user is
|
|
# allowed to close the given issue.
|
|
def close_issue(issue, commit: nil, notifications: true, system_note: true)
|
|
if project.jira_tracker? && project.jira_service.active && issue.is_a?(ExternalIssue)
|
|
project.jira_service.close_issue(commit, issue)
|
|
todo_service.close_issue(issue, current_user)
|
|
return issue
|
|
end
|
|
|
|
if project.issues_enabled? && issue.close
|
|
event_service.close_issue(issue, current_user)
|
|
create_note(issue, commit) if system_note
|
|
notification_service.close_issue(issue, current_user) if notifications
|
|
todo_service.close_issue(issue, current_user)
|
|
execute_hooks(issue, 'close')
|
|
invalidate_cache_counts(issue, users: issue.assignees)
|
|
issue.update_project_counter_caches
|
|
end
|
|
|
|
issue
|
|
end
|
|
|
|
private
|
|
|
|
def create_note(issue, current_commit)
|
|
SystemNoteService.change_status(issue, issue.project, current_user, issue.state, current_commit)
|
|
end
|
|
end
|
|
end
|