615 lines
17 KiB
Ruby
615 lines
17 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe Ci::Build, models: true do
|
|
let(:project) { FactoryGirl.create :project }
|
|
let(:commit) { FactoryGirl.create :ci_commit, project: project }
|
|
let(:build) { FactoryGirl.create :ci_build, commit: commit }
|
|
|
|
it { is_expected.to validate_presence_of :ref }
|
|
|
|
it { is_expected.to respond_to :trace_html }
|
|
|
|
describe '#first_pending' do
|
|
let(:first) { FactoryGirl.create :ci_build, commit: commit, status: 'pending', created_at: Date.yesterday }
|
|
let(:second) { FactoryGirl.create :ci_build, commit: commit, status: 'pending' }
|
|
before { first; second }
|
|
subject { Ci::Build.first_pending }
|
|
|
|
it { is_expected.to be_a(Ci::Build) }
|
|
it('returns with the first pending build') { is_expected.to eq(first) }
|
|
end
|
|
|
|
describe '#create_from' do
|
|
before do
|
|
build.status = 'success'
|
|
build.save
|
|
end
|
|
let(:create_from_build) { Ci::Build.create_from build }
|
|
|
|
it 'there should be a pending task' do
|
|
expect(Ci::Build.pending.count(:all)).to eq 0
|
|
create_from_build
|
|
expect(Ci::Build.pending.count(:all)).to be > 0
|
|
end
|
|
end
|
|
|
|
describe '#ignored?' do
|
|
subject { build.ignored? }
|
|
|
|
context 'if build is not allowed to fail' do
|
|
before { build.allow_failure = false }
|
|
|
|
context 'and build.status is success' do
|
|
before { build.status = 'success' }
|
|
|
|
it { is_expected.to be_falsey }
|
|
end
|
|
|
|
context 'and build.status is failed' do
|
|
before { build.status = 'failed' }
|
|
|
|
it { is_expected.to be_falsey }
|
|
end
|
|
end
|
|
|
|
context 'if build is allowed to fail' do
|
|
before { build.allow_failure = true }
|
|
|
|
context 'and build.status is success' do
|
|
before { build.status = 'success' }
|
|
|
|
it { is_expected.to be_falsey }
|
|
end
|
|
|
|
context 'and build.status is failed' do
|
|
before { build.status = 'failed' }
|
|
|
|
it { is_expected.to be_truthy }
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#trace' do
|
|
subject { build.trace_html }
|
|
|
|
it { is_expected.to be_empty }
|
|
|
|
context 'if build.trace contains text' do
|
|
let(:text) { 'example output' }
|
|
before { build.trace = text }
|
|
|
|
it { is_expected.to include(text) }
|
|
it { expect(subject.length).to be >= text.length }
|
|
end
|
|
|
|
context 'if build.trace hides token' do
|
|
let(:token) { 'my_secret_token' }
|
|
|
|
before do
|
|
build.project.update_attributes(runners_token: token)
|
|
build.update_attributes(trace: token)
|
|
end
|
|
|
|
it { is_expected.not_to include(token) }
|
|
end
|
|
end
|
|
|
|
# TODO: build timeout
|
|
# describe :timeout do
|
|
# subject { build.timeout }
|
|
#
|
|
# it { is_expected.to eq(commit.project.timeout) }
|
|
# end
|
|
|
|
describe '#options' do
|
|
let(:options) do
|
|
{
|
|
image: "ruby:2.1",
|
|
services: [
|
|
"postgres"
|
|
]
|
|
}
|
|
end
|
|
|
|
subject { build.options }
|
|
it { is_expected.to eq(options) }
|
|
end
|
|
|
|
# TODO: allow_git_fetch
|
|
# describe :allow_git_fetch do
|
|
# subject { build.allow_git_fetch }
|
|
#
|
|
# it { is_expected.to eq(project.allow_git_fetch) }
|
|
# end
|
|
|
|
describe '#project' do
|
|
subject { build.project }
|
|
|
|
it { is_expected.to eq(commit.project) }
|
|
end
|
|
|
|
describe '#project_id' do
|
|
subject { build.project_id }
|
|
|
|
it { is_expected.to eq(commit.project_id) }
|
|
end
|
|
|
|
describe '#project_name' do
|
|
subject { build.project_name }
|
|
|
|
it { is_expected.to eq(project.name) }
|
|
end
|
|
|
|
describe '#extract_coverage' do
|
|
context 'valid content & regex' do
|
|
subject { build.extract_coverage('Coverage 1033 / 1051 LOC (98.29%) covered', '\(\d+.\d+\%\) covered') }
|
|
|
|
it { is_expected.to eq(98.29) }
|
|
end
|
|
|
|
context 'valid content & bad regex' do
|
|
subject { build.extract_coverage('Coverage 1033 / 1051 LOC (98.29%) covered', 'very covered') }
|
|
|
|
it { is_expected.to be_nil }
|
|
end
|
|
|
|
context 'no coverage content & regex' do
|
|
subject { build.extract_coverage('No coverage for today :sad:', '\(\d+.\d+\%\) covered') }
|
|
|
|
it { is_expected.to be_nil }
|
|
end
|
|
|
|
context 'multiple results in content & regex' do
|
|
subject { build.extract_coverage(' (98.39%) covered. (98.29%) covered', '\(\d+.\d+\%\) covered') }
|
|
|
|
it { is_expected.to eq(98.29) }
|
|
end
|
|
|
|
context 'using a regex capture' do
|
|
subject { build.extract_coverage('TOTAL 9926 3489 65%', 'TOTAL\s+\d+\s+\d+\s+(\d{1,3}\%)') }
|
|
|
|
it { is_expected.to eq(65) }
|
|
end
|
|
end
|
|
|
|
describe '#variables' do
|
|
context 'returns variables' do
|
|
subject { build.variables }
|
|
|
|
let(:predefined_variables) do
|
|
[
|
|
{ key: :CI_BUILD_NAME, value: 'test', public: true },
|
|
{ key: :CI_BUILD_STAGE, value: 'stage', public: true },
|
|
]
|
|
end
|
|
|
|
let(:yaml_variables) do
|
|
[
|
|
{ key: :DB_NAME, value: 'postgres', public: true }
|
|
]
|
|
end
|
|
|
|
before { build.update_attributes(stage: 'stage') }
|
|
|
|
it { is_expected.to eq(predefined_variables + yaml_variables) }
|
|
|
|
context 'for tag' do
|
|
let(:tag_variable) do
|
|
[
|
|
{ key: :CI_BUILD_TAG, value: 'master', public: true }
|
|
]
|
|
end
|
|
|
|
before { build.update_attributes(tag: true) }
|
|
|
|
it { is_expected.to eq(tag_variable + predefined_variables + yaml_variables) }
|
|
end
|
|
|
|
context 'and secure variables' do
|
|
let(:secure_variables) do
|
|
[
|
|
{ key: 'SECRET_KEY', value: 'secret_value', public: false }
|
|
]
|
|
end
|
|
|
|
before do
|
|
build.project.variables << Ci::Variable.new(key: 'SECRET_KEY', value: 'secret_value')
|
|
end
|
|
|
|
it { is_expected.to eq(predefined_variables + yaml_variables + secure_variables) }
|
|
|
|
context 'and trigger variables' do
|
|
let(:trigger) { FactoryGirl.create :ci_trigger, project: project }
|
|
let(:trigger_request) { FactoryGirl.create :ci_trigger_request_with_variables, commit: commit, trigger: trigger }
|
|
let(:trigger_variables) do
|
|
[
|
|
{ key: :TRIGGER_KEY, value: 'TRIGGER_VALUE', public: false }
|
|
]
|
|
end
|
|
let(:predefined_trigger_variable) do
|
|
[
|
|
{ key: :CI_BUILD_TRIGGERED, value: 'true', public: true }
|
|
]
|
|
end
|
|
|
|
before do
|
|
build.trigger_request = trigger_request
|
|
end
|
|
|
|
it { is_expected.to eq(predefined_variables + predefined_trigger_variable + yaml_variables + secure_variables + trigger_variables) }
|
|
end
|
|
|
|
context 'when job variables are defined' do
|
|
##
|
|
# Job-level variables are defined in gitlab_ci.yml fixture
|
|
#
|
|
context 'when job variables are unique' do
|
|
let(:build) { create(:ci_build, name: 'staging') }
|
|
|
|
it 'includes job variables' do
|
|
expect(subject).to include(
|
|
{ key: :KEY1, value: 'value1', public: true },
|
|
{ key: :KEY2, value: 'value2', public: true }
|
|
)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#can_be_served?' do
|
|
let(:runner) { create(:ci_runner) }
|
|
|
|
before { build.project.runners << runner }
|
|
|
|
context 'when runner does not have tags' do
|
|
it 'can handle builds without tags' do
|
|
expect(build.can_be_served?(runner)).to be_truthy
|
|
end
|
|
|
|
it 'cannot handle build with tags' do
|
|
build.tag_list = ['aa']
|
|
expect(build.can_be_served?(runner)).to be_falsey
|
|
end
|
|
end
|
|
|
|
context 'when runner has tags' do
|
|
before { runner.tag_list = ['bb', 'cc'] }
|
|
|
|
shared_examples 'tagged build picker' do
|
|
it 'can handle build with matching tags' do
|
|
build.tag_list = ['bb']
|
|
expect(build.can_be_served?(runner)).to be_truthy
|
|
end
|
|
|
|
it 'cannot handle build without matching tags' do
|
|
build.tag_list = ['aa']
|
|
expect(build.can_be_served?(runner)).to be_falsey
|
|
end
|
|
end
|
|
|
|
context 'when runner can pick untagged jobs' do
|
|
it 'can handle builds without tags' do
|
|
expect(build.can_be_served?(runner)).to be_truthy
|
|
end
|
|
|
|
it_behaves_like 'tagged build picker'
|
|
end
|
|
|
|
context 'when runner can not pick untagged jobs' do
|
|
before { runner.run_untagged = false }
|
|
|
|
it 'can not handle builds without tags' do
|
|
expect(build.can_be_served?(runner)).to be_falsey
|
|
end
|
|
|
|
it_behaves_like 'tagged build picker'
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#has_tags?' do
|
|
context 'when build has tags' do
|
|
subject { create(:ci_build, tag_list: ['tag']) }
|
|
it { is_expected.to have_tags }
|
|
end
|
|
|
|
context 'when build does not have tags' do
|
|
subject { create(:ci_build, tag_list: []) }
|
|
it { is_expected.not_to have_tags }
|
|
end
|
|
end
|
|
|
|
describe '#any_runners_online?' do
|
|
subject { build.any_runners_online? }
|
|
|
|
context 'when no runners' do
|
|
it { is_expected.to be_falsey }
|
|
end
|
|
|
|
context 'if there are runner' do
|
|
let(:runner) { FactoryGirl.create :ci_runner }
|
|
|
|
before do
|
|
build.project.runners << runner
|
|
runner.update_attributes(contacted_at: 1.second.ago)
|
|
end
|
|
|
|
it { is_expected.to be_truthy }
|
|
|
|
it 'that is inactive' do
|
|
runner.update_attributes(active: false)
|
|
is_expected.to be_falsey
|
|
end
|
|
|
|
it 'that is not online' do
|
|
runner.update_attributes(contacted_at: nil)
|
|
is_expected.to be_falsey
|
|
end
|
|
|
|
it 'that cannot handle build' do
|
|
expect_any_instance_of(Ci::Build).to receive(:can_be_served?).and_return(false)
|
|
is_expected.to be_falsey
|
|
end
|
|
|
|
end
|
|
end
|
|
|
|
describe '#stuck?' do
|
|
subject { build.stuck? }
|
|
|
|
%w(pending).each do |state|
|
|
context "if commit_status.status is #{state}" do
|
|
before { build.status = state }
|
|
|
|
it { is_expected.to be_truthy }
|
|
|
|
context "and there are specific runner" do
|
|
let(:runner) { FactoryGirl.create :ci_runner, contacted_at: 1.second.ago }
|
|
|
|
before do
|
|
build.project.runners << runner
|
|
runner.save
|
|
end
|
|
|
|
it { is_expected.to be_falsey }
|
|
end
|
|
end
|
|
end
|
|
|
|
%w(success failed canceled running).each do |state|
|
|
context "if commit_status.status is #{state}" do
|
|
before { build.status = state }
|
|
|
|
it { is_expected.to be_falsey }
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#artifacts?' do
|
|
subject { build.artifacts? }
|
|
|
|
context 'artifacts archive does not exist' do
|
|
before { build.update_attributes(artifacts_file: nil) }
|
|
it { is_expected.to be_falsy }
|
|
end
|
|
|
|
context 'artifacts archive exists' do
|
|
let(:build) { create(:ci_build, :artifacts) }
|
|
it { is_expected.to be_truthy }
|
|
end
|
|
end
|
|
|
|
|
|
describe '#artifacts_metadata?' do
|
|
subject { build.artifacts_metadata? }
|
|
context 'artifacts metadata does not exist' do
|
|
it { is_expected.to be_falsy }
|
|
end
|
|
|
|
context 'artifacts archive is a zip file and metadata exists' do
|
|
let(:build) { create(:ci_build, :artifacts) }
|
|
it { is_expected.to be_truthy }
|
|
end
|
|
end
|
|
|
|
describe '#repo_url' do
|
|
let(:build) { FactoryGirl.create :ci_build }
|
|
let(:project) { build.project }
|
|
|
|
subject { build.repo_url }
|
|
|
|
it { is_expected.to be_a(String) }
|
|
it { is_expected.to end_with(".git") }
|
|
it { is_expected.to start_with(project.web_url[0..6]) }
|
|
it { is_expected.to include(build.token) }
|
|
it { is_expected.to include('gitlab-ci-token') }
|
|
it { is_expected.to include(project.web_url[7..-1]) }
|
|
end
|
|
|
|
describe '#depends_on_builds' do
|
|
let!(:build) { FactoryGirl.create :ci_build, commit: commit, name: 'build', stage_idx: 0, stage: 'build' }
|
|
let!(:rspec_test) { FactoryGirl.create :ci_build, commit: commit, name: 'rspec', stage_idx: 1, stage: 'test' }
|
|
let!(:rubocop_test) { FactoryGirl.create :ci_build, commit: commit, name: 'rubocop', stage_idx: 1, stage: 'test' }
|
|
let!(:staging) { FactoryGirl.create :ci_build, commit: commit, name: 'staging', stage_idx: 2, stage: 'deploy' }
|
|
|
|
it 'to have no dependents if this is first build' do
|
|
expect(build.depends_on_builds).to be_empty
|
|
end
|
|
|
|
it 'to have one dependent if this is test' do
|
|
expect(rspec_test.depends_on_builds.map(&:id)).to contain_exactly(build.id)
|
|
end
|
|
|
|
it 'to have all builds from build and test stage if this is last' do
|
|
expect(staging.depends_on_builds.map(&:id)).to contain_exactly(build.id, rspec_test.id, rubocop_test.id)
|
|
end
|
|
|
|
it 'to have retried builds instead the original ones' do
|
|
retried_rspec = Ci::Build.retry(rspec_test)
|
|
expect(staging.depends_on_builds.map(&:id)).to contain_exactly(build.id, retried_rspec.id, rubocop_test.id)
|
|
end
|
|
end
|
|
|
|
def create_mr(build, commit, factory: :merge_request, created_at: Time.now)
|
|
FactoryGirl.create(factory,
|
|
source_project_id: commit.gl_project_id,
|
|
target_project_id: commit.gl_project_id,
|
|
source_branch: build.ref,
|
|
created_at: created_at)
|
|
end
|
|
|
|
describe '#merge_request' do
|
|
context 'when a MR has a reference to the commit' do
|
|
before do
|
|
@merge_request = create_mr(build, commit, factory: :merge_request)
|
|
|
|
commits = [double(id: commit.sha)]
|
|
allow(@merge_request).to receive(:commits).and_return(commits)
|
|
allow(MergeRequest).to receive_message_chain(:includes, :where, :reorder).and_return([@merge_request])
|
|
end
|
|
|
|
it 'returns the single associated MR' do
|
|
expect(build.merge_request.id).to eq(@merge_request.id)
|
|
end
|
|
end
|
|
|
|
context 'when there is not a MR referencing the commit' do
|
|
it 'returns nil' do
|
|
expect(build.merge_request).to be_nil
|
|
end
|
|
end
|
|
|
|
context 'when more than one MR have a reference to the commit' do
|
|
before do
|
|
@merge_request = create_mr(build, commit, factory: :merge_request)
|
|
@merge_request.close!
|
|
@merge_request2 = create_mr(build, commit, factory: :merge_request)
|
|
|
|
commits = [double(id: commit.sha)]
|
|
allow(@merge_request).to receive(:commits).and_return(commits)
|
|
allow(@merge_request2).to receive(:commits).and_return(commits)
|
|
allow(MergeRequest).to receive_message_chain(:includes, :where, :reorder).and_return([@merge_request, @merge_request2])
|
|
end
|
|
|
|
it 'returns the first MR' do
|
|
expect(build.merge_request.id).to eq(@merge_request.id)
|
|
end
|
|
end
|
|
|
|
context 'when a Build is created after the MR' do
|
|
before do
|
|
@merge_request = create_mr(build, commit, factory: :merge_request_with_diffs)
|
|
commit2 = FactoryGirl.create :ci_commit, project: project
|
|
@build2 = FactoryGirl.create :ci_build, commit: commit2
|
|
|
|
commits = [double(id: commit.sha), double(id: commit2.sha)]
|
|
allow(@merge_request).to receive(:commits).and_return(commits)
|
|
allow(MergeRequest).to receive_message_chain(:includes, :where, :reorder).and_return([@merge_request])
|
|
end
|
|
|
|
it 'returns the current MR' do
|
|
expect(@build2.merge_request.id).to eq(@merge_request.id)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'build erasable' do
|
|
shared_examples 'erasable' do
|
|
it 'should remove artifact file' do
|
|
expect(build.artifacts_file.exists?).to be_falsy
|
|
end
|
|
|
|
it 'should remove artifact metadata file' do
|
|
expect(build.artifacts_metadata.exists?).to be_falsy
|
|
end
|
|
|
|
it 'should erase build trace in trace file' do
|
|
expect(build.trace).to be_empty
|
|
end
|
|
|
|
it 'should set erased to true' do
|
|
expect(build.erased?).to be true
|
|
end
|
|
|
|
it 'should set erase date' do
|
|
expect(build.erased_at).not_to be_falsy
|
|
end
|
|
end
|
|
|
|
context 'build is not erasable' do
|
|
let!(:build) { create(:ci_build) }
|
|
|
|
describe '#erase' do
|
|
subject { build.erase }
|
|
|
|
it { is_expected.to be false }
|
|
end
|
|
|
|
describe '#erasable?' do
|
|
subject { build.erasable? }
|
|
it { is_expected.to eq false }
|
|
end
|
|
end
|
|
|
|
context 'build is erasable' do
|
|
let!(:build) { create(:ci_build, :trace, :success, :artifacts) }
|
|
|
|
describe '#erase' do
|
|
before { build.erase(erased_by: user) }
|
|
|
|
context 'erased by user' do
|
|
let!(:user) { create(:user, username: 'eraser') }
|
|
|
|
include_examples 'erasable'
|
|
|
|
it 'should record user who erased a build' do
|
|
expect(build.erased_by).to eq user
|
|
end
|
|
end
|
|
|
|
context 'erased by system' do
|
|
let(:user) { nil }
|
|
|
|
include_examples 'erasable'
|
|
|
|
it 'should not set user who erased a build' do
|
|
expect(build.erased_by).to be_nil
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#erasable?' do
|
|
subject { build.erasable? }
|
|
it { is_expected.to eq true }
|
|
end
|
|
|
|
describe '#erased?' do
|
|
let!(:build) { create(:ci_build, :trace, :success, :artifacts) }
|
|
subject { build.erased? }
|
|
|
|
context 'build has not been erased' do
|
|
it { is_expected.to be false }
|
|
end
|
|
|
|
context 'build has been erased' do
|
|
before { build.erase }
|
|
|
|
it { is_expected.to be true }
|
|
end
|
|
end
|
|
|
|
context 'metadata and build trace are not available' do
|
|
let!(:build) { create(:ci_build, :success, :artifacts) }
|
|
before { build.remove_artifacts_metadata! }
|
|
|
|
describe '#erase' do
|
|
it 'should not raise error' do
|
|
expect { build.erase }.not_to raise_error
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|