kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/app/models
History
Rémy Coutable 9a7afd2a63 Merge branch '22655-deployments-don-t-always-have-keep-around-refs' into 'master' 
Handle case where deployment ref no longer exists

## What does this MR do?

In 8.9, we didn't create keep-around refs for deployments. So it's possible that someone created a deployment (say, for testing), and then deleted the branch and all other references to that commit. That commit could then get GCed, and trying to view MRs on 8.11+ will show a 500. See https://gitlab.com/gitlab-org/gitlab-ce/issues/22655#note_16575020 for more details.

## Why was this MR needed?

If someone created a deployment on 8.9, then deleted all references to the commit for that deployment, we will throw an exception when checking if the deployment includes a commit.

Closes #22655.

See merge request !6855
2016-10-13 16:33:19 +00:00
..
ci Schedule async pipeline success worker after commit 2016-10-12 12:07:58 +02:00
concerns Add markdown cache columns to the database, but don't use them yet 2016-10-07 02:54:25 +01:00
cycle_analytics Fix the "Commits" section of the cycle analytics summary. 2016-09-26 18:38:40 +05:30
hooks Scope hooks thal will run for confidential issues 2016-08-31 18:34:45 -03:00
issue Implement (some) comments from @DouweM's review. 2016-09-20 18:13:11 +05:30
members Allow Member.add_user to handle access requesters 2016-09-28 09:43:00 +02:00
merge_request Implement (some) comments from @DouweM's review. 2016-09-20 18:13:11 +05:30
network
project_services Changed Slack service user referencing from full name to username 2016-10-03 00:44:47 +02:00
protected_branch Backport changes from gitlab-org/gitlab-ee!581 to CE. 2016-08-16 11:05:14 +05:30
.gitkeep
ability.rb factor out a RuleSet so that delegate! retains @cannot 2016-08-30 11:39:22 -07:00
abuse_report.rb Add markdown cache columns to the database, but don't use them yet 2016-10-07 02:54:25 +01:00
appearance.rb Add markdown cache columns to the database, but don't use them yet 2016-10-07 02:54:25 +01:00
application_setting.rb Add markdown cache columns to the database, but don't use them yet 2016-10-07 02:54:25 +01:00
audit_event.rb
award_emoji.rb
blob.rb Handle encoding in non-binary Blob instances 2016-09-14 14:15:31 +02:00
board.rb Improve project_with_board factory to create the default lists 2016-09-26 14:42:38 -03:00
broadcast_message.rb Add markdown cache columns to the database, but don't use them yet 2016-10-07 02:54:25 +01:00
commit.rb Fix Commit#status, feedback: 2016-09-14 01:25:26 +08:00
commit_range.rb Enable Lint/StringConversionInInterpolation cop and autocorrect offenses 2016-10-03 16:09:57 +02:00
commit_status.rb Do not return from proc-closure in pipeline transition 2016-10-12 15:21:11 +02:00
compare.rb Refactor straight compare diff code 2016-10-12 16:32:57 +03:00
cycle_analytics.rb updated var name based on feedback 2016-10-13 09:19:30 +02:00
deploy_key.rb Refactor LFS token logic to use a Redis key instead of a DB field, making it a 1 use only token. 2016-09-15 12:21:00 -05:00
deploy_keys_project.rb
deployment.rb Handle case where deployment ref no longer exists 2016-10-13 16:15:38 +01:00
diff_note.rb Optimize discussion notes resolving and unresolving 2016-09-06 12:14:09 -03:00
discussion.rb Optimize discussion notes resolving and unresolving 2016-09-06 12:14:09 -03:00
email.rb
environment.rb deployment refs in own folder, new method for creating refs 2016-10-04 09:54:31 +02:00
event.rb Make guests unable to view MRs 2016-10-11 16:51:26 +03:00
external_issue.rb
forked_project_link.rb
generic_commit_status.rb
global_label.rb Add markdown cache columns to the database, but don't use them yet 2016-10-07 02:54:25 +01:00
global_milestone.rb Add markdown cache columns to the database, but don't use them yet 2016-10-07 02:54:25 +01:00
group.rb Allow Member.add_user to handle access requesters 2016-09-28 09:43:00 +02:00
identity.rb
issue.rb Use the IssuableBaseService lifecycle hooks to cache MergeRequestsClosingIssues 2016-09-21 01:22:20 +05:30
key.rb
label.rb Add markdown cache columns to the database, but don't use them yet 2016-10-07 02:54:25 +01:00
label_link.rb
legacy_diff_note.rb Move #to_discussion to NoteOnDiff 2016-08-30 16:30:42 +01:00
lfs_object.rb
lfs_objects_project.rb
list.rb Add a movable scope and a movable? method to List model 2016-08-17 12:58:59 -03:00
member.rb Make Member#add_user set access_level for requesters 2016-10-03 11:24:16 +02:00
merge_request.rb MergeRequest new form load diff asynchronously 2016-10-06 11:19:14 +02:00
merge_request_diff.rb Refactor straight compare diff code 2016-10-12 16:32:57 +03:00
merge_requests_closing_issues.rb Implement a second round of review comments from @DouweM. 2016-09-21 00:47:37 +05:30
milestone.rb Add markdown cache columns to the database, but don't use them yet 2016-10-07 02:54:25 +01:00
namespace.rb Correct namespace validation to forbid bad names #21077 2016-10-07 13:46:59 -05:00
note.rb Use CacheMarkdownField for notes 2016-10-07 02:54:26 +01:00
notification_setting.rb
oauth_access_token.rb
personal_access_token.rb
personal_snippet.rb
project.rb Add Project::BoardLimitExcedeed error class 2016-10-11 11:39:05 -03:00
project_feature.rb Fix project deletion when feature visibility is set to private 2016-10-04 20:53:15 -07:00
project_group_link.rb Merge branch 'api-fix-project-group-sharing' into 'security' 2016-10-11 20:36:26 +02:00
project_import_data.rb
project_snippet.rb
project_team.rb Allow Member.add_user to handle access requesters 2016-09-28 09:43:00 +02:00
project_wiki.rb
protected_branch.rb Backport changes from gitlab-org/gitlab-ee!581 to CE. 2016-08-16 11:05:14 +05:30
release.rb Add markdown cache columns to the database, but don't use them yet 2016-10-07 02:54:25 +01:00
repository.rb Merge branch '20708-new-branch-is-immediatelly-tagged-as-merged' into 'master' 2016-10-12 10:17:35 +00:00
security_event.rb
sent_notification.rb
service.rb Fix issues importing services via Import/Export 2016-10-04 10:01:32 +02:00
snippet.rb Add markdown cache columns to the database, but don't use them yet 2016-10-07 02:54:25 +01:00
spam_log.rb Allow SpamLog to be submitted as ham 2016-08-15 13:18:15 -05:00
subscription.rb
todo.rb Todos sorting dropdown 2016-08-19 16:14:20 -03:00
tree.rb
trending_project.rb Precalculate trending projects 2016-10-10 12:27:08 +02:00
u2f_registration.rb Allow naming U2F devices. 2016-08-18 22:12:02 +05:30
user.rb Add a safeguard in User#set_projects_limit 2016-10-11 10:21:26 +02:00
user_agent_detail.rb Further refactor and syntax fixes. 2016-08-15 17:20:57 -05:00
users_star_project.rb
wiki_page.rb