Douwe Maan 5042f008ed Merge branch 'cleanup-mentionable-methods-arguments' into 'master' ... Simplify Mentionable concern instance methods ## What does this MR do? Simplify arguments received by the instance methods on the concern so in the closer future will be easy to understand and change ## Are there points in the code the reviewer needs to double check? ## Why was this MR needed? ## Screenshots (if relevant) ## Does this MR meet the acceptance criteria? - [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [ ] All builds are passing - [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if you do - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? See merge request !6596		2016-10-04 10:51:45 +00:00
..
auth	Be nice to Docker Clients talking to JWT/auth	2016-09-27 16:59:05 +02:00
boards	Fix issue boards leak private label names and descriptions	2016-08-29 16:04:28 -03:00
ci	Make the cases clear instead of having guards	2016-09-12 18:49:58 +08:00
commits	Reduce duplication in Commits::{CherryPickService,RevertService}	2016-09-15 16:30:27 +02:00
files	Add optional 'author' param when making commits	2016-09-19 10:00:26 -07:00
groups
issuable	Add bulk update support for merge requests list	2016-09-08 11:52:20 +03:00
issues	Add bulk update support for merge requests list	2016-09-08 11:52:20 +03:00
members	Invert method's naming	2016-10-03 16:57:48 +02:00
merge_requests	Add a /wip slash command	2016-10-03 09:36:21 +02:00
milestones	Ensure validation messages are shown within the milestone form	2016-09-19 09:29:12 +01:00
notes	Ensure we have a user before checking for their permission in Notes::SlashCommandsService	2016-09-20 13:58:14 +02:00
oauth2
projects	fix broken repo 500 errors in UI and added relevant specs	2016-09-29 16:58:14 +02:00
protected_branches	Backport changes from gitlab-org/gitlab-ee!581 to CE.	2016-08-16 11:05:14 +05:30
search
slash_commands	Add a /wip slash command	2016-10-03 09:36:21 +02:00
wiki_pages
akismet_service.rb	Reduce duplication in AkismetService	2016-09-20 08:19:32 +03:00
audit_event_service.rb
base_service.rb	remove Ability.abilities	2016-08-30 11:35:06 -07:00
compare_service.rb	switch from diff_file_collection to diffs	2016-08-03 07:00:20 +02:00
create_branch_service.rb
create_deployment_service.rb	Implement a second round of review comments from @DouweM.	2016-09-21 00:47:37 +05:30
create_release_service.rb
create_snippet_service.rb
create_tag_service.rb
delete_branch_service.rb	Simplify the name for data builder, feedback:	2016-08-12 16:09:29 +08:00
delete_tag_service.rb	Simplify the name for data builder, feedback:	2016-08-12 16:09:29 +08:00
delete_user_service.rb	Fix bug where destroying a namespace would not always destroy projects	2016-08-11 15:36:35 -07:00
destroy_group_service.rb	Fix bug where destroying a namespace would not always destroy projects	2016-08-11 15:36:35 -07:00
event_create_service.rb
git_hooks_service.rb
git_push_service.rb	Implement review comments from @yorickpeterse	2016-09-20 16:05:25 +05:30
git_tag_push_service.rb	Simplify the name for data builder, feedback:	2016-08-12 16:09:29 +08:00
gravatar_service.rb
ham_service.rb	Further refactor and syntax fixes.	2016-08-15 17:20:57 -05:00
import_export_clean_up_service.rb	using shared path for project import uploads and refactored gitlab remove export worker	2016-08-04 12:51:55 +02:00
issuable_base_service.rb	Fix permission for setting an issue's due date	2016-09-28 17:41:32 +02:00
notification_service.rb	Fix RuboCop failure in app/services/notification_service.rb	2016-10-02 15:03:11 +02:00
repair_ldap_blocked_user_service.rb
repository_archive_clean_up_service.rb	using shared path for project import uploads and refactored gitlab remove export worker	2016-08-04 12:51:55 +02:00
spam_service.rb	Further refactor and syntax fixes.	2016-08-15 17:20:57 -05:00
system_hooks_service.rb	Enable Lint/StringConversionInInterpolation cop and autocorrect offenses	2016-10-03 16:09:57 +02:00
system_note_service.rb	Use SELECT 1, instead SELECT COUNT(*) to ask for notes existency	2016-10-04 10:45:49 +02:00
test_hook_service.rb	Simplify the name for data builder, feedback:	2016-08-12 16:09:29 +08:00
todo_service.rb	Refresh todos count cache when an Issue/MR is deleted	2016-09-08 15:50:07 -03:00
update_release_service.rb
update_snippet_service.rb
user_agent_detail_service.rb	Further refactor and syntax fixes.	2016-08-15 17:20:57 -05:00