9d2be75674
When logging arguments from Sidekiq to JSON, restrict the size of `args` to 10 KB (when converted to JSON). This is to avoid blowing up with excessively large job payloads.
115 lines
3 KiB
Ruby
115 lines
3 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
module Gitlab
|
|
module SidekiqLogging
|
|
class StructuredLogger
|
|
START_TIMESTAMP_FIELDS = %w[created_at enqueued_at].freeze
|
|
DONE_TIMESTAMP_FIELDS = %w[started_at retried_at failed_at completed_at].freeze
|
|
MAXIMUM_JOB_ARGUMENTS_LENGTH = 10.kilobytes
|
|
|
|
def call(job, queue)
|
|
started_at = current_time
|
|
base_payload = parse_job(job)
|
|
|
|
Sidekiq.logger.info log_job_start(started_at, base_payload)
|
|
|
|
yield
|
|
|
|
Sidekiq.logger.info log_job_done(started_at, base_payload)
|
|
rescue => job_exception
|
|
Sidekiq.logger.warn log_job_done(started_at, base_payload, job_exception)
|
|
|
|
raise
|
|
end
|
|
|
|
private
|
|
|
|
def base_message(payload)
|
|
"#{payload['class']} JID-#{payload['jid']}"
|
|
end
|
|
|
|
def log_job_start(started_at, payload)
|
|
payload['message'] = "#{base_message(payload)}: start"
|
|
payload['job_status'] = 'start'
|
|
|
|
payload
|
|
end
|
|
|
|
def log_job_done(started_at, payload, job_exception = nil)
|
|
payload = payload.dup
|
|
payload['duration'] = elapsed(started_at)
|
|
payload['completed_at'] = Time.now.utc
|
|
|
|
message = base_message(payload)
|
|
|
|
if job_exception
|
|
payload['message'] = "#{message}: fail: #{payload['duration']} sec"
|
|
payload['job_status'] = 'fail'
|
|
payload['error_message'] = job_exception.message
|
|
payload['error'] = job_exception.class
|
|
payload['error_backtrace'] = backtrace_cleaner.clean(job_exception.backtrace)
|
|
else
|
|
payload['message'] = "#{message}: done: #{payload['duration']} sec"
|
|
payload['job_status'] = 'done'
|
|
end
|
|
|
|
convert_to_iso8601(payload, DONE_TIMESTAMP_FIELDS)
|
|
|
|
payload
|
|
end
|
|
|
|
def parse_job(job)
|
|
job = job.dup
|
|
|
|
# Add process id params
|
|
job['pid'] = ::Process.pid
|
|
|
|
job.delete('args') unless ENV['SIDEKIQ_LOG_ARGUMENTS']
|
|
job['args'] = limited_job_args(job['args']) if job['args']
|
|
|
|
convert_to_iso8601(job, START_TIMESTAMP_FIELDS)
|
|
|
|
job
|
|
end
|
|
|
|
def convert_to_iso8601(payload, keys)
|
|
keys.each do |key|
|
|
payload[key] = format_time(payload[key]) if payload[key]
|
|
end
|
|
end
|
|
|
|
def elapsed(start)
|
|
(current_time - start).round(3)
|
|
end
|
|
|
|
def current_time
|
|
Gitlab::Metrics::System.monotonic_time
|
|
end
|
|
|
|
def backtrace_cleaner
|
|
@backtrace_cleaner ||= ActiveSupport::BacktraceCleaner.new
|
|
end
|
|
|
|
def format_time(timestamp)
|
|
return timestamp if timestamp.is_a?(String)
|
|
|
|
Time.at(timestamp).utc.iso8601(3)
|
|
end
|
|
|
|
def limited_job_args(args)
|
|
return unless args.is_a?(Array)
|
|
|
|
total_length = 0
|
|
limited_args = args.take_while do |arg|
|
|
total_length += arg.to_json.length
|
|
|
|
total_length <= MAXIMUM_JOB_ARGUMENTS_LENGTH
|
|
end
|
|
|
|
limited_args.push('...') if total_length > MAXIMUM_JOB_ARGUMENTS_LENGTH
|
|
|
|
limited_args
|
|
end
|
|
end
|
|
end
|
|
end
|