bf061d0aff
disable markdown in comments when referencing disabled features fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/23548 This MR prevents the following references when tool is disabled: - issues - snippets - commits - when repo is disabled - commit range - when repo is disabled - milestones This MR does not prevent references to repository files, since they are just markdown links and don't leak information. See merge request !2011 Signed-off-by: Rémy Coutable <remy@rymai.me>
121 lines
3.4 KiB
Ruby
121 lines
3.4 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe Banzai::ReferenceParser::CommitParser, lib: true do
|
|
include ReferenceParserHelpers
|
|
|
|
let(:project) { create(:empty_project, :public) }
|
|
let(:user) { create(:user) }
|
|
subject { described_class.new(project, user) }
|
|
let(:link) { empty_html_link }
|
|
|
|
describe '#nodes_visible_to_user' do
|
|
context 'when the link has a data-issue attribute' do
|
|
before { link['data-commit'] = 123 }
|
|
|
|
it_behaves_like "referenced feature visibility", "repository"
|
|
end
|
|
end
|
|
|
|
describe '#referenced_by' do
|
|
context 'when the link has a data-project attribute' do
|
|
before do
|
|
link['data-project'] = project.id.to_s
|
|
end
|
|
|
|
context 'when the link has a data-commit attribute' do
|
|
before do
|
|
link['data-commit'] = '123'
|
|
end
|
|
|
|
it 'returns an Array of commits' do
|
|
commit = double(:commit)
|
|
|
|
allow_any_instance_of(Project).to receive(:valid_repo?).
|
|
and_return(true)
|
|
|
|
expect(subject).to receive(:find_commits).
|
|
with(project, ['123']).
|
|
and_return([commit])
|
|
|
|
expect(subject.referenced_by([link])).to eq([commit])
|
|
end
|
|
|
|
it 'returns an empty Array when the commit could not be found' do
|
|
allow_any_instance_of(Project).to receive(:valid_repo?).
|
|
and_return(true)
|
|
|
|
expect(subject).to receive(:find_commits).
|
|
with(project, ['123']).
|
|
and_return([])
|
|
|
|
expect(subject.referenced_by([link])).to eq([])
|
|
end
|
|
|
|
it 'skips projects without valid repositories' do
|
|
allow_any_instance_of(Project).to receive(:valid_repo?).
|
|
and_return(false)
|
|
|
|
expect(subject.referenced_by([link])).to eq([])
|
|
end
|
|
end
|
|
|
|
context 'when the link does not have a data-commit attribute' do
|
|
it 'returns an empty Array' do
|
|
allow_any_instance_of(Project).to receive(:valid_repo?).
|
|
and_return(true)
|
|
|
|
expect(subject.referenced_by([link])).to eq([])
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when the link does not have a data-project attribute' do
|
|
it 'returns an empty Array' do
|
|
allow_any_instance_of(Project).to receive(:valid_repo?).
|
|
and_return(true)
|
|
|
|
expect(subject.referenced_by([link])).to eq([])
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#commit_ids_per_project' do
|
|
before do
|
|
link['data-project'] = project.id.to_s
|
|
end
|
|
|
|
it 'returns a Hash containing commit IDs per project' do
|
|
link['data-commit'] = '123'
|
|
|
|
hash = subject.commit_ids_per_project([link])
|
|
|
|
expect(hash).to be_an_instance_of(Hash)
|
|
|
|
expect(hash[project.id].to_a).to eq(['123'])
|
|
end
|
|
|
|
it 'does not add a project when the data-commit attribute is empty' do
|
|
hash = subject.commit_ids_per_project([link])
|
|
|
|
expect(hash).to be_empty
|
|
end
|
|
end
|
|
|
|
describe '#find_commits' do
|
|
it 'returns an Array of commit objects' do
|
|
commit = double(:commit)
|
|
|
|
expect(project).to receive(:commit).with('123').and_return(commit)
|
|
expect(project).to receive(:valid_repo?).and_return(true)
|
|
|
|
expect(subject.find_commits(project, %w{123})).to eq([commit])
|
|
end
|
|
|
|
it 'skips commit IDs for which no commit could be found' do
|
|
expect(project).to receive(:commit).with('123').and_return(nil)
|
|
expect(project).to receive(:valid_repo?).and_return(true)
|
|
|
|
expect(subject.find_commits(project, %w{123})).to eq([])
|
|
end
|
|
end
|
|
end
|