gitlab-org--gitlab-foss

History

Zeger-Jan van de Weg 3ab026b7d6 Use memoization for commits on diffs The Gitaly CommitService is being hammered by n + 1 calls, mostly when finding commits. This leads to this gRPC being turned of on production: https://gitlab.com/gitlab-org/gitaly/issues/514#note_48991378 Hunting down where it came from, most of them were due to MergeRequest#show. To prove this, I set a script to request the MergeRequest#show page 50 times. The GDK was being scraped by Prometheus, where we have metrics on controller#action and their Gitaly calls performed. On both occations I've restarted the full GDK so all caches had to be rebuild. Current master, `806a68a81f`, needed 435 requests After this commit, 154 requests	2017-12-12 16:28:26 +01:00
..
merge_hash.rb	…
strong_memoize.rb	Use memoization for commits on diffs	2017-12-12 16:28:26 +01:00

Zeger-Jan van de Weg 3ab026b7d6

The Gitaly CommitService is being hammered by n + 1 calls, mostly when
finding commits. This leads to this gRPC being turned of on production:
https://gitlab.com/gitlab-org/gitaly/issues/514#note_48991378

Hunting down where it came from, most of them were due to
MergeRequest#show. To prove this, I set a script to request the
MergeRequest#show page 50 times. The GDK was being scraped by
Prometheus, where we have metrics on controller#action and their Gitaly
calls performed. On both occations I've restarted the full GDK so all
caches had to be rebuild.

Current master, 806a68a81f, needed 435 requests
After this commit, 154 requests

2017-12-12 16:28:26 +01:00

merge_hash.rb

…

strong_memoize.rb Use memoization for commits on diffs 2017-12-12 16:28:26 +01:00