gitlab-org--gitlab-foss/app/controllers
Jacob Schatz 39820d8013 Merge branch 'cs-async-branch-dropdown' into 'master'
Load branch dropdowns asynchronously for cherry pick and revert dialogs

## Why was this MR needed and what does it do?

Previously every commit page was loading every branch onto the page twice, once each for the Cherry Pick and Revert modal dialogs. Most of the time they're never used, so that's a bit of a waste.

This loads them asynchronously by modifying the existing ref switcher code to also work for the branch selectors. This is better for performance.

## Are there points in the code the reviewer needs to double check?

Make sure Cherry Picking and Reverting still work (from my tests they seem to be fine).

## What are the relevant issue numbers?

Fixes #20108.

## Screenshots (if relevant)

Before:

![Screen_Shot_2016-08-01_at_4.35.21_PM](/uploads/6b76ea656fd00df52ab56df5309976dc/Screen_Shot_2016-08-01_at_4.35.21_PM.png)

![Screen_Shot_2016-08-01_at_4.35.52_PM](/uploads/d2699a4bfc4ad1a4d414429e7c50e60f/Screen_Shot_2016-08-01_at_4.35.52_PM.png)

After:

![Screen_Shot_2016-08-01_at_4.32.49_PM](/uploads/5faa6494b10dd9ac5e8850763a0c4018/Screen_Shot_2016-08-01_at_4.32.49_PM.png)

![Screen_Shot_2016-08-01_at_4.32.56_PM](/uploads/87c490bb375244e7d72421fd55e13e3f/Screen_Shot_2016-08-01_at_4.32.56_PM.png)

![Screen_Shot_2016-08-01_at_4.33.02_PM](/uploads/59ae65c0afc39d8939a9f36431815854/Screen_Shot_2016-08-01_at_4.33.02_PM.png)

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

cc: @iamphill @jschatz1 

See merge request !5607
2016-08-19 14:48:06 +00:00
..
admin Further refactor and syntax fixes. 2016-08-15 17:20:57 -05:00
ci
concerns Handle legacy sort order values 2016-08-18 23:26:07 +01:00
dashboard Rename TodoService#mark_todos_as_done_by_id{,s} 2016-08-18 17:46:24 +02:00
explore Replace reject_blocked with reject_blocked! in callbacks. 2016-07-27 13:56:30 -06:00
groups
import Fix permissions check in controller, added relevant spec and updated docs 2016-08-11 16:59:37 +02:00
oauth
profiles Address review comments from @smcgivern. 2016-08-18 22:12:02 +05:30
projects Merge branch 'cs-async-branch-dropdown' into 'master' 2016-08-19 14:48:06 +00:00
sherlock
abuse_reports_controller.rb
application_controller.rb State specific default sort order for issuables 2016-08-01 11:28:56 +02:00
autocomplete_controller.rb Move to project dropdown with infinite scroll for better performance 2016-08-17 07:33:51 +02:00
confirmations_controller.rb
dashboard_controller.rb
emojis_controller.rb
groups_controller.rb Fix bug where destroying a namespace would not always destroy projects 2016-08-11 15:36:35 -07:00
health_check_controller.rb
help_controller.rb Replace reject_blocked with reject_blocked! in callbacks. 2016-07-27 13:56:30 -06:00
invites_controller.rb
jwt_controller.rb
namespaces_controller.rb
notification_settings_controller.rb
omniauth_callbacks_controller.rb Added tests for 2FA check on OAuth request 2016-07-04 11:00:34 -05:00
passwords_controller.rb
profiles_controller.rb
projects_controller.rb Fix specs and implement fixes based on failing specs 2016-08-17 17:54:24 -05:00
registrations_controller.rb Enable Style/SpaceAroundEqualsInParameterDefault cop 2016-08-06 04:03:01 +02:00
root_controller.rb
search_controller.rb Replace reject_blocked with reject_blocked! in callbacks. 2016-07-27 13:56:30 -06:00
sent_notifications_controller.rb
sessions_controller.rb Remove provider path, replace with dynamic path. 2016-08-03 11:50:38 -06:00
snippets_controller.rb
uploads_controller.rb
users_controller.rb