4db62fef53
Correct autocomplete for values with special characters ## What does this MR do? This adds a check for any special chars in any value passed to the `DefaultOptions.beforeInsert` callback function. If special chars are found and `skipSpecialCharTest` option is `false`, it will wrap the value in quotation marks. This fixed autocompleting `~customer+` instead of `~"customer+"`. ## Are there points in the code the reviewer needs to double check? ## Why was this MR needed? ## Screenshots (if relevant) ![2016-12-03_10.37.11](/uploads/59159623638939933d23b447692775b8/2016-12-03_10.37.11.gif) ## Does this MR meet the acceptance criteria? - [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [ ] All builds are passing - [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if it does - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #25286, #24961 See merge request !7910 |
||
---|---|---|
.. | ||
admin | ||
atom | ||
boards | ||
dashboard | ||
groups | ||
issuables | ||
issues | ||
merge_requests | ||
milestones | ||
profiles | ||
projects | ||
protected_branches | ||
security | ||
snippets | ||
tags | ||
todos | ||
users | ||
abuse_report_spec.rb | ||
calendar_spec.rb | ||
ci_lint_spec.rb | ||
commits_spec.rb | ||
compare_spec.rb | ||
container_registry_spec.rb | ||
dashboard_issues_spec.rb | ||
dashboard_milestones_spec.rb | ||
environment_spec.rb | ||
environments_spec.rb | ||
expand_collapse_diffs_spec.rb | ||
gitlab_flavored_markdown_spec.rb | ||
global_search_spec.rb | ||
groups_spec.rb | ||
help_pages_spec.rb | ||
issues_spec.rb | ||
login_spec.rb | ||
markdown_spec.rb | ||
milestone_spec.rb | ||
notes_on_merge_requests_spec.rb | ||
participants_autocomplete_spec.rb | ||
password_reset_spec.rb | ||
profile_spec.rb | ||
projects_spec.rb | ||
protected_branches_spec.rb | ||
runners_spec.rb | ||
search_spec.rb | ||
signup_spec.rb | ||
snippets_spec.rb | ||
task_lists_spec.rb | ||
triggers_spec.rb | ||
u2f_spec.rb | ||
unsubscribe_links_spec.rb | ||
users_spec.rb | ||
variables_spec.rb |