8fa9da49c4
Set OmniAuth full_host parameter to ensure redirect URIs are correct ### What does this MR do? This MR sets the OmniAuth `full_host` parameter to the configured GitLab URL to ensure the `redirect_uri` parameter is called with the right GitLab host. ### Why was this MR needed? [OmniAuth attempts to grab the request URI](http://awesomeprogrammer.com/blog/2012/12/09/dealing-with-omniauth-redirect-uri-mismatch-invalid-port-number-gotcha/) and use that. If you set up a reverse proxy that terminates SSL at the Web server layer (e.g. https://gitlab.domain.com), omniauth will use the internal URL (e.g. http://my-host:8080) in its redirect URI unless all the Web server headers are properly set (e.g. `X-Forwarded-Port`, etc.). This is easy to forget or mess up, and it's better to ensure that OmniAuth has the right value from the start. ### What are the relevant issue numbers? Closes #1967 See merge request !991 |
||
---|---|---|
.. | ||
1_settings.rb | ||
2_app.rb | ||
3_grit_ext.rb | ||
4_sidekiq.rb | ||
5_backend.rb | ||
6_rack_profiler.rb | ||
7_omniauth.rb | ||
8_default_url_options.rb | ||
attr_encrypted_no_db_connection.rb | ||
backtrace_silencers.rb | ||
carrierwave.rb | ||
devise.rb | ||
devise_async.rb | ||
devise_password_length.rb.example | ||
disable_email_interceptor.rb | ||
doorkeeper.rb | ||
gitlab_shell_secret_token.rb | ||
haml.rb | ||
inflections.rb | ||
kaminari_config.rb | ||
mime_types.rb | ||
postgresql_limit_fix.rb | ||
public_key.rb | ||
rack_attack.rb.example | ||
rack_attack_git_basic_auth.rb | ||
redis-store-fix-expiry.rb | ||
secret_token.rb | ||
session_store.rb | ||
smtp_settings.rb.sample | ||
state_machine_patch.rb | ||
static_files.rb | ||
time_zone.rb | ||
wrap_parameters.rb |