kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/app/assets/javascripts
History
Jacob Schatz 7b18e8c744 Merge branch '13525-sane-defaults-for-merge-request-js-class-constructor' into 'master' 
Avoid a TypeError when initializing MergeRequest JS class with no arg

## What does this MR do?

Avoid a TypeError when initializing MergeRequest JS class with no arg.

## Are there points in the code the reviewer needs to double check?

No.

## Why was this MR needed?

Without this sane default you would get the following error when you
tried to instantiate a new MergeRequest object with no argument (i.e.
`new MergeRequest();`):
    
    TypeError: undefined is not an object (evaluating 'this.opts.action')

## What are the relevant issue numbers?

Fixes #13525.

## Does this MR meet the acceptance criteria?

- [x] No CHANGELOG since it's a trivial internal change
- [x] Tests
  - [x] Added for this feature/bug
  - [ ] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !4667
2016-06-16 18:32:23 +00:00
..
behaviors Merge branch 'fix-bug-causing-comment-to-submit-twice' into 'master' 2016-04-13 15:04:09 +00:00
blob Implements TemplateDropdown class to create custom template dropdowns 2016-06-16 00:28:45 -05:00
ci Displays time remaining relative to now 2016-06-13 11:08:15 +01:00
commit
extensions
graphs Only load Chart.js when necessary. 2016-06-07 15:27:30 -06:00
lib Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce into category-search-dropdown 2016-06-16 02:04:09 +03:00
network Replace raphael-rails with raphael.js so it can be split from the rest of the JavaScript. The gem isn't maintained anymore anyway. Added a network folder with an application.js including raphael components, since that's the only page using it currently. 2016-06-10 09:28:07 -06:00
u2f Implement authentication (login) using a U2F device. 2016-06-06 12:50:31 +05:30
users Attempt to fix the user page. 2016-06-01 19:42:49 -06:00
activities.js.coffee Update method name for better understanding 2016-06-09 14:38:24 -05:00
admin.js.coffee
api.js.coffee Dropdown implementation 2016-05-20 15:58:36 -05:00
application.js.coffee Merge branch 'network-assets' into 'master' 2016-06-15 21:11:31 +00:00
aside.js.coffee
autosave.js.coffee
awards_handler.coffee Fix emoji block selector. 2016-06-11 00:24:24 +03:00
breakpoints.coffee
broadcast_message.js.coffee
build_artifacts.js.coffee
commit.js.coffee
commits.js.coffee Remove unused param 2016-04-21 00:20:13 +00:00
compare.js.coffee Removed un-used get request 2016-04-06 11:08:40 +01:00
confirm_danger_modal.js.coffee
copy_to_clipboard.js.coffee
diff.js.coffee
dispatcher.js.coffee Merge branch 'milestone-date-clear' into 'master' 2016-06-15 20:52:09 +00:00
dropzone_input.js.coffee Removes dropzone focus class after dropping file 2016-04-15 18:24:16 +01:00
due_date_select.js.coffee Merge branch 'milestone-date-clear' into 'master' 2016-06-15 20:52:09 +00:00
flash.js.coffee Enhancements 2016-06-03 17:14:23 -05:00
gfm_auto_complete.js.coffee Checks based on whether data is loaded not undefined 2016-06-09 17:20:57 -04:00
gl_crop.js.coffee
gl_dropdown.js.coffee Fixed issue with dropdown toggle not updating 2016-06-08 11:45:17 +01:00
gl_form.js.coffee Removed GL Actions class 2016-04-14 10:28:05 +01:00
group_avatar.js.coffee
groups.js.coffee
groups_select.js.coffee
importer_status.js.coffee Addressed feedback 2016-04-18 13:45:26 +01:00
issuable.js.coffee Use Turbolink instead of ajax 2016-06-14 12:39:51 -05:00
issuable_context.js.coffee Fixed issue with project dropdown links not being clickable 2016-04-22 10:57:00 +01:00
issuable_form.js.coffee Fixed issue with move dropdown not being searchable 2016-06-15 08:53:11 +01:00
issue.js.coffee Load the "New Branch" button asynchronously 2016-04-28 16:13:48 -04:00
issue_status_select.js.coffee
issues-bulk-assignment.js.coffee Reinitialize checkboxes to toggle event bindings 2016-06-14 12:39:51 -05:00
LabelManager.js.coffee Add handler icon to prioritized labels 2016-06-15 10:35:58 -05:00
labels.js.coffee
labels_select.js.coffee Merge branch 'issuable-sidebar-bold' into 'master' 2016-06-15 20:29:50 +00:00
layout_nav.js.coffee Removed console.log 2016-06-14 17:53:26 +01:00
line_highlighter.js.coffee
logo.js.coffee Fix #18604, logo in header wasn't an anchor link. 2016-06-14 15:57:46 -06:00
markdown_preview.js.coffee
merge_request.js.coffee Avoid a TypeError when initializing MergeRequest JS class with no arg 2016-06-15 10:33:36 +02:00
merge_request_tabs.js.coffee Fixed issue when opening a highlighted line diff 2016-06-10 17:04:54 +01:00
merge_request_widget.js.coffee Fixed potential issue with 2 ci status polling events happening 2016-05-26 15:24:35 +01:00
merged_buttons.js.coffee Fixed issue with MR buttons being in a group 2016-06-13 11:46:53 +01:00
milestone.js.coffee
milestone_select.js.coffee Merge branch 'issuable-sidebar-bold' into 'master' 2016-06-15 20:29:50 +00:00
namespace_select.js.coffee
new_branch_form.js.coffee
new_commit_form.js.coffee
notes.js.coffee Fix note polling when a window has been hidden 2016-06-13 16:23:38 -04:00
pager.js.coffee Fix local timeago on user dashboard 2016-06-09 14:38:24 -05:00
profile.js.coffee Add null check to formData.append 2016-04-18 13:04:36 -05:00
project.js.coffee Create NotificationSettings object only when user change value in dropdown 2016-03-30 10:44:20 +02:00
project_avatar.js.coffee
project_find_file.js.coffee
project_fork.js.coffee
project_import.js.coffee
project_members.js.coffee
project_new.js.coffee Allow or not merge MR with failed build 2016-06-10 14:36:54 +02:00
project_select.js.coffee Project dropdown in header uses new dropdown 2016-04-12 13:10:43 -04:00
project_show.js.coffee
projects_list.js.coffee
protected_branches.js.coffee
right_sidebar.js.coffee Uses update URL to update the status of a todo 2016-06-14 08:36:07 +01:00
search.js.coffee Focus field 2016-04-26 09:03:04 +01:00
search_autocomplete.js.coffee Refactor search autocomplete to support groups category contents. 2016-06-09 04:22:13 +03:00
shortcuts.js.coffee Added ability to skip the Mousetrap binding reset 2016-06-10 17:41:02 +01:00
shortcuts_blob.coffee Added ability to skip the Mousetrap binding reset 2016-06-10 17:41:02 +01:00
shortcuts_dashboard_navigation.js.coffee Fix dashboard shortcuts 2016-05-17 00:35:16 -05:00
shortcuts_find_file.js.coffee
shortcuts_issuable.coffee Remove prev/next buttons on issues and merge requests 2016-06-06 12:01:50 -04:00
shortcuts_navigation.coffee Set i as a shortcut for creating a new issue 2016-04-18 15:03:36 -05:00
shortcuts_network.js.coffee
sidebar.js.coffee Clicking body closes nav 2016-06-15 18:33:18 +01:00
star.js.coffee Fix project star tooltip on the fly. 2016-06-15 15:14:53 +03:00
subscription.js.coffee Updated subscribe icon 2016-06-09 17:19:14 +01:00
syntax_highlight.coffee
todos.js.coffee Allow middle-click on a Todo row to open in a new tab 2016-04-24 15:01:52 -04:00
tree.js.coffee
user.js.coffee
user_tabs.js.coffee Fix local timeago on user dashboard 2016-06-09 14:38:24 -05:00
users_select.js.coffee Merge branch 'issuable-sidebar-bold' into 'master' 2016-06-15 20:29:50 +00:00
wikis.js.coffee
zen_mode.js.coffee Restyling on elements in comment form 2016-04-04 10:48:49 +01:00