kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/spec/workers
History
Stan Hu bf4455d146 Merge branch 'dont-drop-stuck-builds' into 'master' 
Don't fail builds for projects that are deleted when they are stuck

## What does this MR do?

Solves when dropping stuck connection.
```
Dropping stuck pending build 1545510 for runner 
NoMethodError: undefined method `origin_merge_requests' for nil:NilClass
    from /opt/gitlab/embedded/service/gitlab-rails/app/services/merge_requests/base_service.rb:50:in `merge_request_from'
    from /opt/gitlab/embedded/service/gitlab-rails/app/services/merge_requests/base_service.rb:57:in `each_merge_request'
    from /opt/gitlab/embedded/service/gitlab-rails/app/services/merge_requests/add_todo_when_build_fails_service.rb:5:in `execute'
    from /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/metrics/instrumentation.rb:164:in `execute'
    from /opt/gitlab/embedded/service/gitlab-rails/app/models/commit_status.rb:51:in `block (2 levels) in <class:CommitStatus>'
    from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/state_machines-0.4.0/lib/state_machines/eval_helpers.rb:79:in `call'
...
```

This happens, because that `default_scope` of `Projects` filters returns the projects that are not deleted, where `Ci::Build` doesn't take into account.


See merge request !4609
 		2016-06-15 02:54:19 +00:00
..
repository_check Merge branch 'create-wikis-during-check' into 'master' 2016-05-04 14:10:49 +00:00
build_email_worker_spec.rb Fix specs 2015-12-10 16:16:34 +01:00
delete_user_worker_spec.rb Specs for the DeleteUserService 2016-03-15 22:19:51 +01:00
email_receiver_worker_spec.rb fix specs 2015-11-30 16:12:31 +02:00
emails_on_push_worker_spec.rb Only generate repository push email once 2016-05-11 09:16:01 +01:00
expire_build_artifacts_worker_spec.rb Fix specs 2016-06-14 11:38:34 +02:00
merge_worker_spec.rb Migrate Repository#local_branches from gitlab-ee. 2016-04-01 14:21:08 -05:00
post_receive_spec.rb Rename all `[ci_]commit` to `[ci_]pipeline` in specs and features 2016-06-03 16:22:26 +02:00
project_cache_worker_spec.rb Check if repo exists before attempting to update cache info 2016-03-27 06:17:49 -07:00
repository_fork_worker_spec.rb Cache output of Repository#exists? 2016-03-19 21:54:08 +01:00
repository_import_worker_spec.rb Mask credentials from URL when import of project has failed. 2016-05-18 21:16:36 -05:00
stuck_ci_builds_worker_spec.rb Don't fail builds for projects that are deleted when they are stuck 2016-06-12 15:15:58 +02:00