kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/app/models
History
Douwe Maan 317206300d Merge branch 'configurable-attachment-size' into 'master' 
Support configurable attachment size in Application Settings page

### What does this MR do?

This MR provides the ability to configure the maximum size of an attachment inside a note. A parameter has been added to the Application Settings page.

### Are there points in the code the reviewer needs to double check?

What should be done with the legacy note attachment validation? I added code to make the validation work with the configurable setting. I could see an issue where an admin lowers the limit from 10 megabytes to 5 megabytes, which could cause an existing model to be invalid.

### Why was this MR needed?

We often have attachments that exceed 10 MB, and it would be nice to be able to override the defaults.

### What are the relevant issue numbers / [Feature requests](http://feedback.gitlab.com/)?

See Issue #1258

### Screenshots

Before:

![Screen_Shot_2015-03-29_at_3.06.53_PM](https://gitlab.com/gitlab-org/gitlab-ce/uploads/6013a1dbc8cf61a63e93744149937fa0/Screen_Shot_2015-03-29_at_3.06.53_PM.png)

After:

![Screen_Shot_2015-03-29_at_3.12.34_PM](https://gitlab.com/gitlab-org/gitlab-ce/uploads/f3518af7e8653ba40f0a3579456da6ad/Screen_Shot_2015-03-29_at_3.12.34_PM.png)

See merge request !407
 		2015-04-03 08:47:55 +00:00
..
concerns Merge branch 'group-information-leak' into 'master' 2015-04-01 01:01:38 +00:00
hooks Explicitly define ordering in models using default_scope 2015-02-05 14:20:55 -08:00
members Use `project_member` instead of `team_member`. 2015-03-15 13:50:38 +01:00
network Merge pull request #7999 from cirosantilli/append-inplace 2015-01-21 23:07:15 -08:00
project_services Use relative URL for Markdown references, except in mails. 2015-03-27 10:39:05 +01:00
.gitkeep init commit 2011-10-09 00:36:38 +03:00
ability.rb Merge branch 'fix-restricted-visibility' into 'master' 2015-03-16 17:49:46 +00:00
application_setting.rb Support configurable attachment size via Application Settings 2015-04-02 00:04:08 -07:00
broadcast_message.rb Explicitly define ordering in models using default_scope 2015-02-05 14:20:55 -08:00
commit.rb Rubocop: Style/ElseAlignment enabled 2015-02-02 21:38:50 -08:00
deploy_key.rb Re-annotate models 2014-04-09 15:05:03 +03:00
deploy_keys_project.rb Delete deploy key when last connection to a project is destroyed. 2015-03-17 14:55:43 +01:00
diff_line.rb Refactor Parallel Diff feature and add scrollbars 2014-03-27 09:15:25 +13:00
email.rb Explicitly define ordering in models using default_scope 2015-02-05 14:20:55 -08:00
event.rb Refactor contributions events and write tests for calendar 2015-03-22 13:55:00 -07:00
external_issue.rb Add ExternalIssue base model to make issue referencing more robust for external issue trackers. 2015-02-11 09:21:57 -08:00
forked_project_link.rb Use strong params for 5 more models 2014-06-26 15:00:09 +03:00
group.rb Split up AttachmentUploader. 2015-02-20 15:19:50 +01:00
group_milestone.rb Remove duplicates from group milestone participants list. 2015-02-05 21:26:57 +01:00
identity.rb Re-annotate models 2015-03-04 14:14:00 -08:00
issue.rb Remove old team scopes. 2015-03-15 13:50:38 +01:00
key.rb Explicitly define ordering in models using default_scope 2015-02-05 14:20:55 -08:00
label.rb Apply default scope to labels and remove one for notes 2015-02-05 20:29:41 -08:00
label_link.rb Annotate models 2014-08-25 12:25:02 +03:00
member.rb Explicitly define ordering in models using default_scope 2015-02-05 14:20:55 -08:00
merge_request.rb Don't mark merge request as updated when merge status relative to target branch changes. 2015-03-23 17:30:19 +01:00
merge_request_diff.rb Explicitly define ordering in models using default_scope 2015-02-05 14:20:55 -08:00
milestone.rb Fix method overlap for issue sorting 2015-02-05 16:49:41 -08:00
namespace.rb Move files for moved namespaces. 2015-03-31 09:30:34 +02:00
note.rb Support configurable attachment size via Application Settings 2015-04-02 00:04:08 -07:00
notification.rb New feature: add 'Mention' notification level 2014-12-29 15:55:21 +02:00
personal_snippet.rb annotate 2014-10-09 18:22:20 +03:00
project.rb Use more specific regexes. 2015-03-27 11:09:29 +01:00
project_snippet.rb annotate 2014-10-09 18:22:20 +03:00
project_team.rb Use `member` instead of `tm`. 2015-03-15 13:50:38 +01:00
project_wiki.rb Fix dots in Wiki slug causing errors 2015-03-21 18:33:51 -07:00
protected_branch.rb Annotate models 2015-01-22 09:40:03 -08:00
repository.rb Archive repositories in background worker. 2015-03-31 12:52:20 +02:00
service.rb Fix external wiki service 2015-03-17 22:59:45 -07:00
snippet.rb Use more specific regexes. 2015-03-27 11:09:29 +01:00
subscription.rb tests 2015-03-16 21:38:41 +02:00
tree.rb Fix tree readme. 2015-03-18 14:08:26 +01:00
user.rb Use more specific regexes. 2015-03-27 11:09:29 +01:00
users_star_project.rb Annotate models 2014-08-25 12:25:02 +03:00
wiki_page.rb Fix dots in Wiki slug causing errors 2015-03-21 18:33:51 -07:00