cb8a425ba4
There is a race condition in DestroyGroupService now that projects are deleted asynchronously: 1. User attempts to delete group 2. DestroyGroupService iterates through all projects and schedules a Sidekiq job to delete each Project 3. DestroyGroupService destroys the Group, leaving all its projects without a namespace 4. Projects::DestroyService runs later but the can?(current_user, :remove_project) is `false` because the user no longer has permission to destroy projects with no namespace. 5. This leaves the project in pending_delete state with no namespace/group. Projects without a namespace or group also adds another problem: it's not possible to destroy the container registry tags, since container_registry_path_with_namespace is the wrong value. The fix is to destroy the group asynchronously and to run execute directly on Projects::DestroyService. Closes #17893 |
||
|---|---|---|
| .. | ||
| repository_check | ||
| admin_email_worker.rb | ||
| build_email_worker.rb | ||
| delete_user_worker.rb | ||
| email_receiver_worker.rb | ||
| emails_on_push_worker.rb | ||
| expire_build_artifacts_worker.rb | ||
| git_garbage_collect_worker.rb | ||
| gitlab_shell_worker.rb | ||
| group_destroy_worker.rb | ||
| import_export_project_cleanup_worker.rb | ||
| irker_worker.rb | ||
| merge_worker.rb | ||
| new_note_worker.rb | ||
| post_receive.rb | ||
| project_cache_worker.rb | ||
| project_destroy_worker.rb | ||
| project_export_worker.rb | ||
| project_service_worker.rb | ||
| project_web_hook_worker.rb | ||
| repository_archive_cache_worker.rb | ||
| repository_fork_worker.rb | ||
| repository_import_worker.rb | ||
| requests_profiles_worker.rb | ||
| stuck_ci_builds_worker.rb | ||
| system_hook_worker.rb | ||