c5645a6739
git-lfs 2.5.0 now sets the Content-Type header instead of hard-coding it to application/octet-stream: https://github.com/git-lfs/git-lfs/pull/3137 To avoid this issue, we explicitly tell the client to use application/octet-stream. Closes #49752
121 lines
2.9 KiB
Ruby
121 lines
2.9 KiB
Ruby
class Projects::LfsApiController < Projects::GitHttpClientController
|
|
include LfsRequest
|
|
|
|
LFS_TRANSFER_CONTENT_TYPE = 'application/octet-stream'.freeze
|
|
|
|
skip_before_action :lfs_check_access!, only: [:deprecated]
|
|
before_action :lfs_check_batch_operation!, only: [:batch]
|
|
|
|
def batch
|
|
unless objects.present?
|
|
render_lfs_not_found
|
|
return
|
|
end
|
|
|
|
if download_request?
|
|
render json: { objects: download_objects! }
|
|
elsif upload_request?
|
|
render json: { objects: upload_objects! }
|
|
else
|
|
raise "Never reached"
|
|
end
|
|
end
|
|
|
|
def deprecated
|
|
render(
|
|
json: {
|
|
message: 'Server supports batch API only, please update your Git LFS client to version 1.0.1 and up.',
|
|
documentation_url: "#{Gitlab.config.gitlab.url}/help"
|
|
},
|
|
status: :not_implemented
|
|
)
|
|
end
|
|
|
|
private
|
|
|
|
def download_request?
|
|
params[:operation] == 'download'
|
|
end
|
|
|
|
def upload_request?
|
|
params[:operation] == 'upload'
|
|
end
|
|
|
|
def existing_oids
|
|
@existing_oids ||= begin
|
|
project.all_lfs_objects.where(oid: objects.map { |o| o['oid'].to_s }).pluck(:oid)
|
|
end
|
|
end
|
|
|
|
def download_objects!
|
|
objects.each do |object|
|
|
if existing_oids.include?(object[:oid])
|
|
object[:actions] = download_actions(object)
|
|
|
|
if Guest.can?(:download_code, project)
|
|
object[:authenticated] = true
|
|
end
|
|
else
|
|
object[:error] = {
|
|
code: 404,
|
|
message: "Object does not exist on the server or you don't have permissions to access it"
|
|
}
|
|
end
|
|
end
|
|
objects
|
|
end
|
|
|
|
def upload_objects!
|
|
objects.each do |object|
|
|
object[:actions] = upload_actions(object) unless existing_oids.include?(object[:oid])
|
|
end
|
|
objects
|
|
end
|
|
|
|
def download_actions(object)
|
|
{
|
|
download: {
|
|
href: "#{project.http_url_to_repo}/gitlab-lfs/objects/#{object[:oid]}",
|
|
header: {
|
|
Authorization: request.headers['Authorization']
|
|
}.compact
|
|
}
|
|
}
|
|
end
|
|
|
|
def upload_actions(object)
|
|
{
|
|
upload: {
|
|
href: "#{project.http_url_to_repo}/gitlab-lfs/objects/#{object[:oid]}/#{object[:size]}",
|
|
header: {
|
|
Authorization: request.headers['Authorization'],
|
|
# git-lfs v2.5.0 sets the Content-Type based on the uploaded file. This
|
|
# ensures that Workhorse can intercept the request.
|
|
'Content-Type': LFS_TRANSFER_CONTENT_TYPE
|
|
}.compact
|
|
}
|
|
}
|
|
end
|
|
|
|
def lfs_check_batch_operation!
|
|
if batch_operation_disallowed?
|
|
render(
|
|
json: {
|
|
message: lfs_read_only_message
|
|
},
|
|
content_type: LfsRequest::CONTENT_TYPE,
|
|
status: 403
|
|
)
|
|
end
|
|
end
|
|
|
|
# Overridden in EE
|
|
def batch_operation_disallowed?
|
|
upload_request? && Gitlab::Database.read_only?
|
|
end
|
|
|
|
# Overridden in EE
|
|
def lfs_read_only_message
|
|
_('You cannot write to this read-only GitLab instance.')
|
|
end
|
|
end
|