kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/spec/features
History
Fatih Acet 286f10afb9 Merge branch 'fix-todo-pagination' into 'master' 
Fix bug where pagination is still displayed despite all todos marked as done

## What does this MR do?
Changes the todo `mark all as done` button callback to remove pagination and add user friendly text `"You're all done!"` so that it is consistent with what the page should look like after refreshing

## Are there points in the code the reviewer needs to double check?
Shouldn't be

## Why was this MR needed?
Resolve existing UI inconsistency

## Screenshots (if relevant)
Before:
![8xDRiXB1TL](/uploads/479edbdedf8d468b4c5e502f36a0c19f/8xDRiXB1TL.gif)

After:
![q4XDxhujPX](/uploads/3566eb538e6ad5a2d32b78351b9bc47d/q4XDxhujPX.gif)

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?
Closes #21048

See merge request !6113
 		2016-08-31 20:26:12 +00:00
..
admin Handle unavailable system info 2016-08-25 08:28:35 +01:00
atom fixes part1 of files to start using active tense 2016-08-09 15:06:23 +01:00
boards Added search for all lists on issue boards 2016-08-30 10:32:19 +01:00
dashboard fixes part1 of files to start using active tense 2016-08-09 15:06:23 +01:00
groups/members Fix a few nitpicks 2016-07-20 14:38:21 +02:00
issuables Handle legacy sort order values 2016-08-18 23:26:07 +01:00
issues Fixed escaping issue with labels filter 2016-08-31 11:41:16 +01:00
merge_requests Fix diff comments on legacy MRs 2016-08-30 09:19:57 +01:00
profiles Remove sleeping and replace escaped text. 2016-08-13 00:57:40 -05:00
projects Merge remote-tracking branch 'upstream/master' into artifacts-from-ref-and-build-name 2016-08-24 20:56:30 +08:00
protected_branches Move protected branches access control spec into a shared example. 2016-08-20 00:24:12 +05:30
security Support integration with Koding (online IDE) 2016-08-19 12:10:58 -07:00
tags
…
todos Fix bug where pagination is still displayed despite all todos marked as done 2016-08-31 10:27:04 -05:00
ci_lint_spec.rb fixes part1 of files to start using active tense 2016-08-09 15:06:23 +01:00
commits_spec.rb fixes part1 of files to start using active tense 2016-08-09 15:06:23 +01:00
compare_spec.rb fixes part1 of files to start using active tense 2016-08-09 15:06:23 +01:00
container_registry_spec.rb
…
dashboard_issues_spec.rb fixes part1 of files to start using active tense 2016-08-09 15:06:23 +01:00
dashboard_milestones_spec.rb
…
environments_spec.rb Add an URL field to Environments 2016-07-29 13:54:45 +02:00
expand_collapse_diffs_spec.rb Collapsed diffs lines/size don't accumulate to overflow diffs. 2016-07-18 14:43:28 -06:00
gitlab_flavored_markdown_spec.rb fixes part1 of files to start using active tense 2016-08-09 15:06:23 +01:00
groups_spec.rb Fix creating group with space in group path 2016-07-14 15:31:48 -03:00
help_pages_spec.rb fixes part1 of files to start using active tense 2016-08-09 15:06:23 +01:00
issues_spec.rb Revert the revert of Optimistic Locking 2016-08-22 18:43:13 +03:00
login_spec.rb fixes part1 of files to start using active tense 2016-08-09 15:06:23 +01:00
markdown_spec.rb Remove VideoJS and clean the integration 2016-07-20 11:36:42 +02:00
milestone_spec.rb fixes part1 of files to start using active tense 2016-08-09 15:06:23 +01:00
notes_on_merge_requests_spec.rb Capitalize mentioned issue timeline notes 2016-08-25 10:47:40 -05:00
participants_autocomplete_spec.rb fixes part1 of files to start using active tense 2016-08-09 15:06:23 +01:00
password_reset_spec.rb
…
pipelines_settings_spec.rb Create PipelinesSettingsController for showing settings page 2016-07-20 14:39:06 +02:00
profile_spec.rb fixes part1 of files to start using active tense 2016-08-09 15:06:23 +01:00
projects_spec.rb Fix file links on project page Files view 2016-08-23 11:01:20 +01:00
protected_branches_spec.rb Move protected branches access control spec into a shared example. 2016-08-20 00:24:12 +05:30
runners_spec.rb
…
search_spec.rb Fixed enter key in search input not working 2016-08-23 14:44:28 +02:00
signup_spec.rb
…
task_lists_spec.rb Shorten task status phrase 2016-08-29 10:46:36 -05:00
triggers_spec.rb
…
u2f_spec.rb Add feature specs to cover naming and deleting U2F devices. 2016-08-18 22:12:02 +05:30
users_spec.rb
…
variables_spec.rb Updated tests 2016-08-13 00:57:40 -05:00