gitlab-org--gitlab-foss/spec
Robert Speicher 939e9bdde1 Make the 'issuables list meta-data' shared example less dangerous
This shared example would take an object's database ID and create a
number of objects based on it. If for some reason the ID were a high
number, like 20, this would create `20 + 21 + 22` objects.

Not only was this dangerous from a performance perspective, it was
entirely unnecessary, as the behavior it was testing is already
well-tested in the unit test for the underlying object. For a controller
test, which is what's including this shared example, all we need to do
is verify that the assigned object contains the correct `id => object`
Hash, which is what we now test for.
2017-08-01 12:55:57 -04:00
..
bin
config
controllers Make the 'issuables list meta-data' shared example less dangerous 2017-08-01 12:55:57 -04:00
db/production Remove superfluous lib: true, type: redis, service: true, models: true, services: true, no_db: true, api: true 2017-07-27 14:31:53 +02:00
factories Merge branch '33620-remove-events-from-notification_settings' into 'master' 2017-08-01 14:54:56 +00:00
features Merge branch '28283-legacy-storage-format' into 'master' 2017-08-01 12:24:24 +00:00
finders Remove superfluous lib: true, type: redis, service: true, models: true, services: true, no_db: true, api: true 2017-07-27 14:31:53 +02:00
fixtures Fix the /projects/:id/repository/branches endpoint to handle dots in the branch name when the project full patch contains a `/` 2017-07-27 14:29:31 +02:00
helpers Rename many path_with_namespace -> full_path 2017-08-01 07:26:58 +02:00
initializers Use described_class when possible 2017-07-27 14:31:53 +02:00
javascripts Merge branch '32483-jira-error' into 'master' 2017-07-28 07:21:04 +00:00
lib Merge branch 'blob-limit-test' into 'master' 2017-08-01 12:53:57 +00:00
mailers notification email on add new gpg key 2017-07-27 15:40:41 +02:00
migrations Rename ensure_dir_exist -> ensure_storage_path_exist 2017-08-01 07:44:25 +02:00
models Merge branch '33620-remove-events-from-notification_settings' into 'master' 2017-08-01 14:54:56 +00:00
policies Use described_class when possible 2017-07-27 14:31:53 +02:00
presenters
requests Merge branch '33620-remove-events-from-notification_settings' into 'master' 2017-08-01 14:54:56 +00:00
routing Remove superfluous lib: true, type: redis, service: true, models: true, services: true, no_db: true, api: true 2017-07-27 14:31:53 +02:00
rubocop/cop
serializers Merge branch '35338-deploy-keys-should-not-show-pending-delete-projects' into 'master' 2017-07-26 08:27:41 +00:00
services Merge branch '28283-legacy-storage-format' into 'master' 2017-08-01 12:24:24 +00:00
sidekiq/cron
support Make the 'issuables list meta-data' shared example less dangerous 2017-08-01 12:55:57 -04:00
tasks Merge branch '28283-legacy-storage-format' into 'master' 2017-08-01 12:24:24 +00:00
unicorn
uploaders
validators
views Fix 500 error when rendering avatar for deleted project creator 2017-07-28 15:23:40 +00:00
workers Rename ensure_dir_exist -> ensure_storage_path_exist 2017-08-01 07:44:25 +02:00
factories_spec.rb
rails_helper.rb
rake_helper.rb
simplecov_env.rb
spec_helper.rb Remove events column from notification settings 2017-07-31 11:18:55 +01:00