7a5c4cd0ca
Peek attempts to serialize results with `to_json`, which calls `ActiveSupport::JSON`. If an object is passed to `to_json` that contains instance variables, `ActiveSupport` will attempt to recursively traverse all variables. The problem is that we can get into an infinite loop if the instance references to an instance that references to something else that points back to the same instance. To avoid this mess, we just call `to_s` on the object. It appears only `Gitlab::Git::Repository` and `::Repository` are the culprits here. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/65404
42 lines
1.4 KiB
Ruby
42 lines
1.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
describe Peek::Views::Rugged, :request_store do
|
|
subject { described_class.new }
|
|
|
|
let(:project) { create(:project) }
|
|
|
|
before do
|
|
allow(Gitlab::RuggedInstrumentation).to receive(:peek_enabled?).and_return(true)
|
|
end
|
|
|
|
it 'returns no results' do
|
|
expect(subject.results).to eq({})
|
|
end
|
|
|
|
it 'returns aggregated results' do
|
|
::Gitlab::RuggedInstrumentation.query_time += 1.234
|
|
::Gitlab::RuggedInstrumentation.increment_query_count
|
|
::Gitlab::RuggedInstrumentation.increment_query_count
|
|
|
|
::Gitlab::RuggedInstrumentation.add_call_details(feature: :rugged_test,
|
|
args: [project.repository.raw, 'HEAD'],
|
|
duration: 0.123)
|
|
::Gitlab::RuggedInstrumentation.add_call_details(feature: :rugged_test2,
|
|
args: [project.repository, 'refs/heads/master'],
|
|
duration: 0.456)
|
|
|
|
results = subject.results
|
|
expect(results[:calls]).to eq(2)
|
|
expect(results[:duration]).to eq('1234.00ms')
|
|
expect(results[:details].count).to eq(2)
|
|
|
|
expected = [
|
|
[project.repository.raw.to_s, "HEAD"],
|
|
[project.repository.to_s, "refs/heads/master"]
|
|
]
|
|
|
|
expect(results[:details].map { |data| data[:args] }).to match_array(expected)
|
|
end
|
|
end
|