6fdb17cbbe
- Add a `destroy_user` ability. This didn't exist before, and was implicit in other abilities (only admins could access the admin area, so only they could destroy all users; a user can only access their own account page, and so can destroy only themselves). - Grant this ability to admins, and when the current user is trying to destroy themselves. Disallow destroying ghost users in all cases. - Modify the `Users::DestroyService` to check this ability. Also check it in views to decide whether or not to show the "Delete User" button. - Add a short summary of the Ghost User to the bio.
37 lines
1 KiB
Ruby
37 lines
1 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe UserPolicy, models: true do
|
|
let(:current_user) { create(:user) }
|
|
let(:user) { create(:user) }
|
|
|
|
subject { described_class.abilities(current_user, user).to_set }
|
|
|
|
describe "reading a user's information" do
|
|
it { is_expected.to include(:read_user) }
|
|
end
|
|
|
|
describe "destroying a user" do
|
|
context "when a regular user tries to destroy another regular user" do
|
|
it { is_expected.not_to include(:destroy_user) }
|
|
end
|
|
|
|
context "when a regular user tries to destroy themselves" do
|
|
let(:current_user) { user }
|
|
|
|
it { is_expected.to include(:destroy_user) }
|
|
end
|
|
|
|
context "when an admin user tries to destroy a regular user" do
|
|
let(:current_user) { create(:user, :admin) }
|
|
|
|
it { is_expected.to include(:destroy_user) }
|
|
end
|
|
|
|
context "when an admin user tries to destroy a ghost user" do
|
|
let(:current_user) { create(:user, :admin) }
|
|
let(:user) { create(:user, :ghost) }
|
|
|
|
it { is_expected.not_to include(:destroy_user) }
|
|
end
|
|
end
|
|
end
|