ff8a053d5d
* The spec has 7 failures at this point * Specify rendered error messages * Render the GitAccess message rather than “Access denied” * Render the Not Found message provided by GitAccess, instead of a custom one * Expect GitAccess to check the config for whether Git-over-HTTP pull or push is disabled, rather than doing it in the controller * Add more thorough testing for authentication * Dried up a lot of tests * Fixed some broken tests
143 lines
4.4 KiB
Ruby
143 lines
4.4 KiB
Ruby
module Gitlab
|
|
module Checks
|
|
class ChangeAccess
|
|
ERROR_MESSAGES = {
|
|
push_code: 'You are not allowed to push code to this project.',
|
|
delete_default_branch: 'The default branch of a project cannot be deleted.',
|
|
force_push_protected_branch: 'You are not allowed to force push code to a protected branch on this project.',
|
|
non_master_delete_protected_branch: 'You are not allowed to delete protected branches from this project. Only a project master or owner can delete a protected branch.',
|
|
non_web_delete_protected_branch: 'You can only delete protected branches using the web interface.',
|
|
merge_protected_branch: 'You are not allowed to merge code into protected branches on this project.',
|
|
push_protected_branch: 'You are not allowed to push code to protected branches on this project.',
|
|
change_existing_tags: 'You are not allowed to change existing tags on this project.',
|
|
update_protected_tag: 'Protected tags cannot be updated.',
|
|
delete_protected_tag: 'Protected tags cannot be deleted.',
|
|
create_protected_tag: 'You are not allowed to create this tag as it is protected.'
|
|
}.freeze
|
|
|
|
attr_reader :user_access, :project, :skip_authorization, :protocol
|
|
|
|
def initialize(
|
|
change, user_access:, project:, skip_authorization: false,
|
|
protocol:
|
|
)
|
|
@oldrev, @newrev, @ref = change.values_at(:oldrev, :newrev, :ref)
|
|
@branch_name = Gitlab::Git.branch_name(@ref)
|
|
@tag_name = Gitlab::Git.tag_name(@ref)
|
|
@user_access = user_access
|
|
@project = project
|
|
@skip_authorization = skip_authorization
|
|
@protocol = protocol
|
|
end
|
|
|
|
def exec
|
|
return GitAccessStatus.new(true) if skip_authorization
|
|
|
|
error = push_checks || branch_checks || tag_checks
|
|
|
|
if error
|
|
GitAccessStatus.new(false, error)
|
|
else
|
|
GitAccessStatus.new(true)
|
|
end
|
|
end
|
|
|
|
protected
|
|
|
|
def push_checks
|
|
if user_access.cannot_do_action?(:push_code)
|
|
ERROR_MESSAGES[:push_code]
|
|
end
|
|
end
|
|
|
|
def branch_checks
|
|
return unless @branch_name
|
|
|
|
if deletion? && @branch_name == project.default_branch
|
|
return ERROR_MESSAGES[:delete_default_branch]
|
|
end
|
|
|
|
protected_branch_checks
|
|
end
|
|
|
|
def protected_branch_checks
|
|
return unless ProtectedBranch.protected?(project, @branch_name)
|
|
|
|
if forced_push?
|
|
return ERROR_MESSAGES[:force_push_protected_branch]
|
|
end
|
|
|
|
if deletion?
|
|
protected_branch_deletion_checks
|
|
else
|
|
protected_branch_push_checks
|
|
end
|
|
end
|
|
|
|
def protected_branch_deletion_checks
|
|
unless user_access.can_delete_branch?(@branch_name)
|
|
return ERROR_MESSAGES[:non_master_delete_protected_branch]
|
|
end
|
|
|
|
unless protocol == 'web'
|
|
ERROR_MESSAGES[:non_web_delete_protected_branch]
|
|
end
|
|
end
|
|
|
|
def protected_branch_push_checks
|
|
if matching_merge_request?
|
|
unless user_access.can_merge_to_branch?(@branch_name) || user_access.can_push_to_branch?(@branch_name)
|
|
ERROR_MESSAGES[:merge_protected_branch]
|
|
end
|
|
else
|
|
unless user_access.can_push_to_branch?(@branch_name)
|
|
ERROR_MESSAGES[:push_protected_branch]
|
|
end
|
|
end
|
|
end
|
|
|
|
def tag_checks
|
|
return unless @tag_name
|
|
|
|
if tag_exists? && user_access.cannot_do_action?(:admin_project)
|
|
return ERROR_MESSAGES[:change_existing_tags]
|
|
end
|
|
|
|
protected_tag_checks
|
|
end
|
|
|
|
def protected_tag_checks
|
|
return unless ProtectedTag.protected?(project, @tag_name)
|
|
|
|
return ERROR_MESSAGES[:update_protected_tag] if update?
|
|
return ERROR_MESSAGES[:delete_protected_tag] if deletion?
|
|
|
|
unless user_access.can_create_tag?(@tag_name)
|
|
return ERROR_MESSAGES[:create_protected_tag]
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def tag_exists?
|
|
project.repository.tag_exists?(@tag_name)
|
|
end
|
|
|
|
def forced_push?
|
|
Gitlab::Checks::ForcePush.force_push?(@project, @oldrev, @newrev)
|
|
end
|
|
|
|
def update?
|
|
!Gitlab::Git.blank_ref?(@oldrev) && !deletion?
|
|
end
|
|
|
|
def deletion?
|
|
Gitlab::Git.blank_ref?(@newrev)
|
|
end
|
|
|
|
def matching_merge_request?
|
|
Checks::MatchingMergeRequest.new(@newrev, @branch_name, @project).match?
|
|
end
|
|
end
|
|
end
|
|
end
|