gitlab-org--gitlab-foss/rubocop/cop/code_reuse/service_class.rb
Yorick Peterse 91c40973dc
Added RuboCop cops to enforce code reuse rules
These Cops enforces the code reuse rules as defined in merge request
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21254.
2018-09-11 15:00:18 +02:00

39 lines
1.1 KiB
Ruby

# frozen_string_literal: true
require_relative '../../code_reuse_helpers.rb'
module RuboCop
module Cop
module CodeReuse
# Cop that enforces various code reuse rules for Service classes.
class ServiceClass < RuboCop::Cop::Cop
include CodeReuseHelpers
IN_FINDER = 'Service classes can not be used in a Finder.'
IN_PRESENTER = 'Service classes can not be used in a Presenter.'
IN_SERIALIZER = 'Service classes can not be used in a Serializer.'
IN_MODEL = 'Service classes can not be used in a model.'
SUFFIX = 'Service'
def on_class(node)
check_all_send_nodes(node)
end
def check_all_send_nodes(node)
message =
if in_finder?(node)
IN_FINDER
elsif in_presenter?(node)
IN_PRESENTER
elsif in_serializer?(node)
IN_SERIALIZER
elsif in_model?(node)
IN_MODEL
end
disallow_send_to(node, SUFFIX, message) if message
end
end
end
end
end