575dced5d7
master was failing because `ApplicationSetting.create_from_defaults` attempted to write to a column that did not exist in the database. This occurred in a `rake db:migrate` task, which was unable to perform the migration that would have added the missing column in the first place. In 9.3 RC2, we also had a bug where password sign-ins were disabled because there were many pending migrations. The problem occurred because `fake_application_settings` was being returned with an OpenStruct that did not include the predicate method `signup_enabled?`. As a result, the value would erroneously return `nil` instead of `true`. This commit uses the values of the defaults to mimic this behavior. This commit also refactors some of the logic to be clearer. |
||
|---|---|---|
| .. | ||
| ci | ||
| abuse_reports.rb | ||
| appearances.rb | ||
| application_settings.rb | ||
| award_emoji.rb | ||
| boards.rb | ||
| broadcast_messages.rb | ||
| chat_names.rb | ||
| chat_teams.rb | ||
| commit_statuses.rb | ||
| commits.rb | ||
| container_repositories.rb | ||
| conversational_development_index_metrics.rb | ||
| deploy_keys_projects.rb | ||
| deployments.rb | ||
| emails.rb | ||
| environments.rb | ||
| events.rb | ||
| file_uploaders.rb | ||
| forked_project_links.rb | ||
| group_members.rb | ||
| groups.rb | ||
| identities.rb | ||
| issues.rb | ||
| keys.rb | ||
| label_links.rb | ||
| label_priorities.rb | ||
| labels.rb | ||
| lfs_objects.rb | ||
| lfs_objects_projects.rb | ||
| lists.rb | ||
| merge_requests.rb | ||
| merge_requests_closing_issues.rb | ||
| milestones.rb | ||
| namespaces.rb | ||
| notes.rb | ||
| notification_settings.rb | ||
| oauth_access_grants.rb | ||
| oauth_access_tokens.rb | ||
| oauth_applications.rb | ||
| pages_domains.rb | ||
| personal_access_tokens.rb | ||
| personal_snippets.rb | ||
| project_group_links.rb | ||
| project_hooks.rb | ||
| project_members.rb | ||
| project_snippets.rb | ||
| project_statistics.rb | ||
| project_wikis.rb | ||
| projects.rb | ||
| protected_branches.rb | ||
| protected_tags.rb | ||
| releases.rb | ||
| sent_notifications.rb | ||
| sequences.rb | ||
| service_hooks.rb | ||
| services.rb | ||
| snippets.rb | ||
| spam_logs.rb | ||
| subscriptions.rb | ||
| system_hooks.rb | ||
| system_note_metadata.rb | ||
| timelogs.rb | ||
| todos.rb | ||
| trending_project.rb | ||
| u2f_registrations.rb | ||
| uploads.rb | ||
| user_agent_details.rb | ||
| users.rb | ||
| web_hook_log.rb | ||
| wiki_directories.rb | ||
| wiki_pages.rb | ||