d3a3db4218
This commit changes how we eager-load projects, routes, and namespaces required by the deploy keys endpoint, getting a 10x improvement in my local testing. The endpoint still doesn't scale in-general, but going from ~13 seconds to dump a 63K result to generating the same thing in ~1.6 seconds seems like a good improvement to me.
25 lines
859 B
Ruby
25 lines
859 B
Ruby
# frozen_string_literal: true
|
|
|
|
class DeployKeysProject < ApplicationRecord
|
|
belongs_to :project, inverse_of: :deploy_keys_projects
|
|
belongs_to :deploy_key, inverse_of: :deploy_keys_projects
|
|
scope :without_project_deleted, -> { joins(:project).where(projects: { pending_delete: false }) }
|
|
scope :in_project, ->(project) { where(project: project) }
|
|
scope :with_write_access, -> { where(can_push: true) }
|
|
|
|
accepts_nested_attributes_for :deploy_key
|
|
|
|
validates :deploy_key, presence: true
|
|
validates :deploy_key_id, uniqueness: { scope: [:project_id], message: "already exists in project" }
|
|
validates :project_id, presence: true
|
|
|
|
after_destroy :destroy_orphaned_deploy_key
|
|
|
|
private
|
|
|
|
def destroy_orphaned_deploy_key
|
|
return unless self.deploy_key.destroyed_when_orphaned? && self.deploy_key.orphaned?
|
|
|
|
self.deploy_key.destroy
|
|
end
|
|
end
|