gitlab-org--gitlab-foss/spec/services
Douwe Maan c003fc5091 Merge branch '23662-issue-move-user-reference-exception' into 'master'
Fix `User#to_reference`

## What does this MR do?

Fix the method signature of `User#to_reference` so that moving an issue with a user reference does not throw a "invalid number of arguments" exception.

## Why was this MR needed?

1. Changes in 8.13 require `Referable`s that don't have a project
   reference to accept two arguments - `from_project` and
   `target_project`.

2. `User#to_reference` was not changed to accept the
   `target_project` (even though it is not used). Moving an issue
   containing a user reference would throw a "invalid number of
   arguments" exception.

3. The regression was introduced in [c8b2b3f7](c8b2b3f7c3 (91fabb7ad88bd2fde6fef1c100a719c00e503047_75_79)), which expects
   all `Referable`s that don't respond to `:project` to have a `to_reference`
   method that takes two arguments.   

## Does this MR meet the acceptance criteria?

- Tests
  - [x] Added for this feature/bug
  - [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

- Closes #23662

See merge request !7088
2016-10-25 10:54:48 +00:00
..
auth Rename capabilities to authentication_abilities 2016-09-16 11:12:21 +02:00
boards Allow user to create a board list based on a group label 2016-10-19 14:58:24 -02:00
ci Space between subject and {, feedback: 2016-10-14 17:08:48 +08:00
files multi-file commit 2016-10-05 17:42:52 +00:00
groups Update tests for the current_application_settings request store changes 2016-05-27 19:05:52 -07:00
issuable Add bulk update support for merge requests list 2016-09-08 11:52:20 +03:00
issues Merge branch '23662-issue-move-user-reference-exception' into 'master' 2016-10-25 10:54:48 +00:00
labels Avoid touch label links that does not belongs to project when moving it 2016-10-19 14:58:28 -02:00
members Merge branch 'rc-improve-members-destroy-service' into 'master' 2016-10-04 10:50:21 +00:00
merge_requests Ignore external issues when bulk assigning issues to author of merge request. 2016-10-20 16:40:24 +02:00
milestones Avoid `describe`-ing symbols in specs 2016-07-12 10:27:58 -05:00
notes Ensure we have a user before checking for their permission in Notes::SlashCommandsService 2016-09-20 13:58:14 +02:00
projects Recreates missing group labels when moving project to another group 2016-10-19 14:58:24 -02:00
protected_branches Add missing spec for ProtectedBranches::CreateService 2016-09-18 13:44:34 -07:00
search Fix visibility of private project snippets for members when searching 2016-06-22 20:09:19 -03:00
slash_commands allow multiple labels commands 2016-10-11 16:38:20 +01:00
compare_service_spec.rb Refactor straight compare diff code 2016-10-12 16:32:57 +03:00
create_deployment_service_spec.rb Merge remote-tracking branch 'origin/master' into 22191-delete-dynamic-envs-mr 2016-10-18 17:48:27 +02:00
create_release_service_spec.rb Tag service specs 2015-12-09 11:55:49 +01:00
create_snippet_service_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
create_tag_service_spec.rb Better message for git hooks and file locks 2016-07-04 15:31:49 +03:00
delete_tag_service_spec.rb Delete tags via rugged 2016-04-15 16:05:04 +02:00
delete_user_service_spec.rb Fix bug where destroying a namespace would not always destroy projects 2016-08-11 15:36:35 -07:00
destroy_group_service_spec.rb Fix bug where destroying a namespace would not always destroy projects 2016-08-11 15:36:35 -07:00
event_create_service_spec.rb Differentiate the expire from leave event 2016-10-20 00:26:45 +00:00
git_hooks_service_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
git_push_service_spec.rb Prevent wrong markdown on issue ids when project has Jira service activated 2016-10-19 13:46:04 -02:00
git_tag_push_service_spec.rb Expire branch/tag git data when needed. 2016-06-30 16:17:38 +02:00
import_export_clean_up_service_spec.rb fix spec 2016-08-04 13:39:38 +02:00
notification_service_spec.rb Make guests unable to view MRs 2016-10-11 16:51:26 +03:00
repair_ldap_blocked_user_service_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
repository_archive_clean_up_service_spec.rb Extract helper methods to clean up RepositoryArchiveCleanUpService spec 2016-07-21 11:47:28 -03:00
search_service_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
system_hooks_service_spec.rb Merge branch 'add_username_to_user_system_hooks' of https://github.com/tbeadle/gitlabhq 2016-01-13 10:12:30 +01:00
system_note_service_spec.rb refactors tests because of gitlab-test repository changes 2016-10-11 16:33:06 +01:00
test_hook_service_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
todo_service_spec.rb Make guests unable to view MRs 2016-10-11 16:51:26 +03:00
update_release_service_spec.rb Tag service specs 2015-12-09 11:55:49 +01:00
update_snippet_service_spec.rb Fix more specs 2016-03-20 23:09:33 +01:00