3d7194f011
The good: - You can do a merge request for a forked commit and it will merge properly (i.e. it does work). - Push events take into account merge requests on forked projects - Tests around merge_actions now present, spinach, and other rspec tests - Satellites now clean themselves up rather then recreate The questionable: - Events only know about target projects - Project's merge requests only hold on to MR's where they are the target - All operations performed in the satellite The bad: - Duplication between project's repositories and satellites (e.g. commits_between) (for reference: http://feedback.gitlab.com/forums/176466-general/suggestions/3456722-merge-requests-between-projects-repos) Fixes: Make test repos/satellites only create when needed -Spinach/Rspec now only initialize test directory, and setup stubs (things that are relatively cheap) -project_with_code, source_project_with_code, and target_project_with_code now create/destroy their repos individually -fixed remote removal -How to merge renders properly -Update emails to show project/branches -Edit MR doesn't set target branch -Fix some failures on editing/creating merge requests, added a test -Added back a test around merge request observer -Clean up project_transfer_spec, Remove duplicate enable/disable observers -Ensure satellite lock files are cleaned up, Attempted to add some testing around these as well -Signifant speed ups for tests -Update formatting ordering in notes_on_merge_requests -Remove wiki schema update Fixes for search/search results -Search results was using by_project for a list of projects, updated this to use in_projects -updated search results to reference the correct (target) project -udpated search results to print both sides of the merge request Change-Id: I19407990a0950945cc95d62089cbcc6262dab1a8
71 lines
2.1 KiB
Ruby
71 lines
2.1 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe IssueObserver do
|
|
let(:some_user) { create :user }
|
|
let(:assignee) { create :user }
|
|
let(:author) { create :user }
|
|
let(:mock_issue) { create(:issue, assignee: assignee, author: author) }
|
|
|
|
|
|
before { subject.stub(:current_user).and_return(some_user) }
|
|
before { subject.stub(notification: mock('NotificationService').as_null_object) }
|
|
|
|
|
|
subject { IssueObserver.instance }
|
|
|
|
describe '#after_create' do
|
|
it 'trigger notification to send emails' do
|
|
subject.should_receive(:notification)
|
|
|
|
subject.after_create(mock_issue)
|
|
end
|
|
end
|
|
|
|
context '#after_close' do
|
|
context 'a status "closed"' do
|
|
before { mock_issue.stub(state: 'closed') }
|
|
|
|
it 'note is created if the issue is being closed' do
|
|
Note.should_receive(:create_status_change_note).with(mock_issue, mock_issue.project, some_user, 'closed')
|
|
|
|
subject.after_close(mock_issue, nil)
|
|
end
|
|
|
|
it 'trigger notification to send emails' do
|
|
subject.notification.should_receive(:close_issue).with(mock_issue, some_user)
|
|
subject.after_close(mock_issue, nil)
|
|
end
|
|
end
|
|
|
|
context 'a status "reopened"' do
|
|
before { mock_issue.stub(state: 'reopened') }
|
|
|
|
it 'note is created if the issue is being reopened' do
|
|
Note.should_receive(:create_status_change_note).with(mock_issue, mock_issue.project, some_user, 'reopened')
|
|
subject.after_reopen(mock_issue, nil)
|
|
end
|
|
end
|
|
end
|
|
|
|
context '#after_update' do
|
|
before(:each) do
|
|
mock_issue.stub(:is_being_reassigned?).and_return(false)
|
|
end
|
|
|
|
context 'notification' do
|
|
it 'triggered if the issue is being reassigned' do
|
|
mock_issue.should_receive(:is_being_reassigned?).and_return(true)
|
|
subject.should_receive(:notification)
|
|
|
|
subject.after_update(mock_issue)
|
|
end
|
|
|
|
it 'is not triggered if the issue is not being reassigned' do
|
|
mock_issue.should_receive(:is_being_reassigned?).and_return(false)
|
|
subject.should_not_receive(:notification)
|
|
|
|
subject.after_update(mock_issue)
|
|
end
|
|
end
|
|
end
|
|
end
|