6fdb17cbbe
- Add a `destroy_user` ability. This didn't exist before, and was implicit in other abilities (only admins could access the admin area, so only they could destroy all users; a user can only access their own account page, and so can destroy only themselves). - Grant this ability to admins, and when the current user is trying to destroy themselves. Disallow destroying ghost users in all cases. - Modify the `Users::DestroyService` to check this ability. Also check it in views to decide whether or not to show the "Delete User" button. - Add a short summary of the Ghost User to the bio.
56 lines
1.8 KiB
Ruby
56 lines
1.8 KiB
Ruby
module Users
|
|
class DestroyService
|
|
attr_accessor :current_user
|
|
|
|
def initialize(current_user)
|
|
@current_user = current_user
|
|
end
|
|
|
|
def execute(user, options = {})
|
|
unless Ability.allowed?(current_user, :destroy_user, user)
|
|
raise Gitlab::Access::AccessDeniedError, "#{current_user} tried to destroy user #{user}!"
|
|
end
|
|
|
|
if !options[:delete_solo_owned_groups] && user.solo_owned_groups.present?
|
|
user.errors[:base] << 'You must transfer ownership or delete groups before you can remove user'
|
|
return user
|
|
end
|
|
|
|
user.solo_owned_groups.each do |group|
|
|
Groups::DestroyService.new(group, current_user).execute
|
|
end
|
|
|
|
user.personal_projects.each do |project|
|
|
# Skip repository removal because we remove directory with namespace
|
|
# that contain all this repositories
|
|
::Projects::DestroyService.new(project, current_user, skip_repo: true).async_execute
|
|
end
|
|
|
|
move_issues_to_ghost_user(user)
|
|
|
|
# Destroy the namespace after destroying the user since certain methods may depend on the namespace existing
|
|
namespace = user.namespace
|
|
user_data = user.destroy
|
|
namespace.really_destroy!
|
|
|
|
user_data
|
|
end
|
|
|
|
private
|
|
|
|
def move_issues_to_ghost_user(user)
|
|
# Block the user before moving issues to prevent a data race.
|
|
# If the user creates an issue after `move_issues_to_ghost_user`
|
|
# runs and before the user is destroyed, the destroy will fail with
|
|
# an exception. We block the user so that issues can't be created
|
|
# after `move_issues_to_ghost_user` runs and before the destroy happens.
|
|
user.block
|
|
|
|
ghost_user = User.ghost
|
|
|
|
user.issues.update_all(author_id: ghost_user.id)
|
|
|
|
user.reload
|
|
end
|
|
end
|
|
end
|