1fe7501b49
This reverts commit cb10b725c8929b8b4460f89c9d96c773af39ba6b.
140 lines
5.3 KiB
Ruby
140 lines
5.3 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe Projects::ImportService, services: true do
|
|
let!(:project) { create(:empty_project) }
|
|
let(:user) { project.creator }
|
|
|
|
subject { described_class.new(project, user) }
|
|
|
|
describe '#execute' do
|
|
context 'with unknown url' do
|
|
before do
|
|
project.import_url = Project::UNKNOWN_IMPORT_URL
|
|
end
|
|
|
|
it 'succeeds if repository is created successfully' do
|
|
expect(project).to receive(:create_repository).and_return(true)
|
|
|
|
result = subject.execute
|
|
|
|
expect(result[:status]).to eq :success
|
|
end
|
|
|
|
it 'fails if repository creation fails' do
|
|
expect(project).to receive(:create_repository).and_return(false)
|
|
|
|
result = subject.execute
|
|
|
|
expect(result[:status]).to eq :error
|
|
expect(result[:message]).to eq 'The repository could not be created.'
|
|
end
|
|
end
|
|
|
|
context 'with known url' do
|
|
before do
|
|
project.import_url = 'https://github.com/vim/vim.git'
|
|
end
|
|
|
|
it 'succeeds if repository import is successfully' do
|
|
expect_any_instance_of(Gitlab::Shell).to receive(:import_repository).with(project.repository_storage_path, project.path_with_namespace, project.import_url).and_return(true)
|
|
|
|
result = subject.execute
|
|
|
|
expect(result[:status]).to eq :success
|
|
end
|
|
|
|
it 'fails if repository import fails' do
|
|
expect_any_instance_of(Gitlab::Shell).to receive(:import_repository).with(project.repository_storage_path, project.path_with_namespace, project.import_url).and_raise(Gitlab::Shell::Error.new('Failed to import the repository'))
|
|
|
|
result = subject.execute
|
|
|
|
expect(result[:status]).to eq :error
|
|
expect(result[:message]).to eq "Error importing repository #{project.import_url} into #{project.path_with_namespace} - Failed to import the repository"
|
|
end
|
|
end
|
|
|
|
context 'with valid importer' do
|
|
before do
|
|
stub_github_omniauth_provider
|
|
|
|
project.import_url = 'https://github.com/vim/vim.git'
|
|
project.import_type = 'github'
|
|
|
|
allow(project).to receive(:import_data).and_return(double.as_null_object)
|
|
end
|
|
|
|
it 'succeeds if importer succeeds' do
|
|
expect_any_instance_of(Gitlab::Shell).to receive(:import_repository).with(project.repository_storage_path, project.path_with_namespace, project.import_url).and_return(true)
|
|
expect_any_instance_of(Gitlab::GithubImport::Importer).to receive(:execute).and_return(true)
|
|
|
|
result = subject.execute
|
|
|
|
expect(result[:status]).to eq :success
|
|
end
|
|
|
|
it 'flushes various caches' do
|
|
expect_any_instance_of(Gitlab::Shell).to receive(:import_repository).
|
|
with(project.repository_storage_path, project.path_with_namespace, project.import_url).
|
|
and_return(true)
|
|
|
|
expect_any_instance_of(Gitlab::GithubImport::Importer).to receive(:execute).
|
|
and_return(true)
|
|
|
|
expect_any_instance_of(Repository).to receive(:expire_emptiness_caches).
|
|
and_call_original
|
|
|
|
expect_any_instance_of(Repository).to receive(:expire_exists_cache).
|
|
and_call_original
|
|
|
|
subject.execute
|
|
end
|
|
|
|
it 'fails if importer fails' do
|
|
expect_any_instance_of(Gitlab::Shell).to receive(:import_repository).with(project.repository_storage_path, project.path_with_namespace, project.import_url).and_return(true)
|
|
expect_any_instance_of(Gitlab::GithubImport::Importer).to receive(:execute).and_return(false)
|
|
|
|
result = subject.execute
|
|
|
|
expect(result[:status]).to eq :error
|
|
expect(result[:message]).to eq 'The remote data could not be imported.'
|
|
end
|
|
|
|
it 'fails if importer raise an error' do
|
|
expect_any_instance_of(Gitlab::Shell).to receive(:import_repository).with(project.repository_storage_path, project.path_with_namespace, project.import_url).and_return(true)
|
|
expect_any_instance_of(Gitlab::GithubImport::Importer).to receive(:execute).and_raise(Projects::ImportService::Error.new('Github: failed to connect API'))
|
|
|
|
result = subject.execute
|
|
|
|
expect(result[:status]).to eq :error
|
|
expect(result[:message]).to eq 'Github: failed to connect API'
|
|
end
|
|
|
|
it 'expires existence cache after error' do
|
|
allow_any_instance_of(Project).to receive(:repository_exists?).and_return(false, true)
|
|
|
|
expect_any_instance_of(Gitlab::Shell).to receive(:import_repository).with(project.repository_storage_path, project.path_with_namespace, project.import_url).and_raise(Gitlab::Shell::Error.new('Failed to import the repository'))
|
|
expect_any_instance_of(Repository).to receive(:expire_emptiness_caches).and_call_original
|
|
expect_any_instance_of(Repository).to receive(:expire_exists_cache).and_call_original
|
|
|
|
subject.execute
|
|
end
|
|
end
|
|
|
|
def stub_github_omniauth_provider
|
|
provider = OpenStruct.new(
|
|
'name' => 'github',
|
|
'app_id' => 'asd123',
|
|
'app_secret' => 'asd123',
|
|
'args' => {
|
|
'client_options' => {
|
|
'site' => 'https://github.com/api/v3',
|
|
'authorize_url' => 'https://github.com/login/oauth/authorize',
|
|
'token_url' => 'https://github.com/login/oauth/access_token'
|
|
}
|
|
}
|
|
)
|
|
|
|
allow(Gitlab.config.omniauth).to receive(:providers).and_return([provider])
|
|
end
|
|
end
|
|
end
|