db0182e261
Extract/mutate `params` in the `execute` method of the API services, rather than in `initialize`.
47 lines
1.6 KiB
Ruby
47 lines
1.6 KiB
Ruby
# The protected branches API still uses the `developers_can_push` and `developers_can_merge`
|
|
# flags for backward compatibility, and so performs translation between that format and the
|
|
# internal data model (separate access levels). The translation code is non-trivial, and so
|
|
# lives in this service.
|
|
module ProtectedBranches
|
|
class ApiUpdateService < BaseService
|
|
def execute(protected_branch)
|
|
@developers_can_push = params.delete(:developers_can_push)
|
|
@developers_can_merge = params.delete(:developers_can_merge)
|
|
|
|
@protected_branch = protected_branch
|
|
|
|
protected_branch.transaction do
|
|
delete_redundant_access_levels
|
|
|
|
case @developers_can_push
|
|
when true
|
|
params.merge!(push_access_levels_attributes: [{ access_level: Gitlab::Access::DEVELOPER }])
|
|
when false
|
|
params.merge!(push_access_levels_attributes: [{ access_level: Gitlab::Access::MASTER }])
|
|
end
|
|
|
|
case @developers_can_merge
|
|
when true
|
|
params.merge!(merge_access_levels_attributes: [{ access_level: Gitlab::Access::DEVELOPER }])
|
|
when false
|
|
params.merge!(merge_access_levels_attributes: [{ access_level: Gitlab::Access::MASTER }])
|
|
end
|
|
|
|
service = ProtectedBranches::UpdateService.new(@project, @current_user, @params)
|
|
service.execute(protected_branch)
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def delete_redundant_access_levels
|
|
unless @developers_can_merge.nil?
|
|
@protected_branch.merge_access_levels.destroy_all
|
|
end
|
|
|
|
unless @developers_can_push.nil?
|
|
@protected_branch.push_access_levels.destroy_all
|
|
end
|
|
end
|
|
end
|
|
end
|